feat: break change, remove is_leaf scalar and use level instead#271
Merged
MaojiaSheng merged 8 commits intovolcengine:mainfrom Feb 25, 2026
Merged
feat: break change, remove is_leaf scalar and use level instead#271MaojiaSheng merged 8 commits intovolcengine:mainfrom
MaojiaSheng merged 8 commits intovolcengine:mainfrom
Conversation
… creation - Create new LogConfig class to wrap all log-related configuration - Update OpenVikingConfig to use nested log config instead of separate fields - Add log rotation support with TimedRotatingFileHandler in logger.py - Add configure_uvicorn_logging to make uvicorn use OpenViking's logging config - Fix empty file being created in current directory by properly handling log.output=file in logging_init.py - Update examples/ov.conf.example to use new nested log config structure - Update __init__.py to export LogConfig and initialize_openviking_config
|
openviking seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
Author
|
related issue: #274 |
zhoujh01
approved these changes
Feb 25, 2026
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes