Conversation
- 重构 is_closing 为基类正式 property,移除 getattr 防御性调用 - 测试用例使用唯一 account ID 避免跨测试数据冲突 - 服务器测试使用独立临时目录避免并发竞争 - 修复 ResourceWarning 测试因历史警告导致的误报 - 修复 CLI grep 命令参数顺序 - 更新路径遍历测试断言为 ValueError - 移除已废弃的 CompressManager 测试 - 改进 AGFS_LIB_PATH 环境变量路径发现逻辑 - 新增 ragas/datasets/pandas 测试依赖 - 改进 CLI 服务器启动失败时的错误输出 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zhoujh01
approved these changes
Feb 28, 2026
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
is_closing为基类正式 property,消除防御性getattr调用CompressManager测试,修正路径遍历安全断言变更内容
重构
VikingVectorIndexBackend基类新增is_closingproperty(默认返回False)collection_schemas.py中getattr(self._vikingdb, "is_closing", False)改为直接属性访问测试修复
test_admin_api.py/test_api_key_manager.py/test_auth.py:每个测试用例使用uuid生成唯一 account ID,避免跨测试冲突tests/server/conftest.py:temp_dirfixture 使用唯一子目录,避免并发测试目录竞争tests/misc/test_port_check.py:在断言前先清理历史ResourceWarning,修复误报tests/agfs/test_fs_binding.py:确保测试目录存在tests/cli/test_cli.py:修复grep命令参数顺序tests/cli/conftest.py:统一使用workspace配置,改进服务器启动失败时的错误输出清理
TestCompressionEdgeCases测试类及CompressManager导入ValueError异常依赖
pyproject.toml新增ragas>=0.1.0、datasets>=2.0.0、pandas>=2.0.0测试依赖AGFS SDK
binding_client.py改进AGFS_LIB_PATH环境变量处理:支持指向文件或目录测试计划
pytest tests/server -v验证服务器测试隔离性pytest tests/cli -v验证 CLI 测试pytest tests/misc -v验证端口检测测试稳定性pytest tests/test_edge_cases.py -v验证边界用例pytest通过🤖 Generated with Claude Code