Skip to content

fix(cli): support git@ SSH URL format in add-resource#411

Merged
qin-ctx merged 1 commit intomainfrom
fix/support-git-ssh-url
Mar 4, 2026
Merged

fix(cli): support git@ SSH URL format in add-resource#411
qin-ctx merged 1 commit intomainfrom
fix/support-git-ssh-url

Conversation

@myysy
Copy link
Collaborator

@myysy myysy commented Mar 4, 2026

  • CLI: Add git@ URL recognition in path validation

This fixes the error when using git@ SSH URLs like:
ov add-resource 'git@github.com:user/repo.git'

Description

Related Issue

[Bug]: Error when using git@ SSH URLs #412

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

- CLI: Add git@ URL recognition in path validation

This fixes the error when using git@ SSH URLs like:
  ov add-resource 'git@github.com:user/repo.git'
@myysy myysy force-pushed the fix/support-git-ssh-url branch from cb79e34 to 1e5a2e9 Compare March 4, 2026 09:14
@myysy myysy changed the title fix(cli,server): support git@ SSH URL format in add-resource fix(cli): support git@ SSH URL format in add-resource Mar 4, 2026
@qin-ctx qin-ctx merged commit f6716f3 into main Mar 4, 2026
11 checks passed
@qin-ctx qin-ctx deleted the fix/support-git-ssh-url branch March 4, 2026 09:59
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants