Skip to content

ci: enhance PR review with severity classification and checklist#437

Merged
zhoujh01 merged 2 commits intomainfrom
ci/enhance-pr-review-instructions
Mar 5, 2026
Merged

ci: enhance PR review with severity classification and checklist#437
zhoujh01 merged 2 commits intomainfrom
ci/enhance-pr-review-instructions

Conversation

@qin-ctx
Copy link
Collaborator

@qin-ctx qin-ctx commented Mar 5, 2026

Description

增强 PR 自动审查的指令,添加严重程度分类和审查 checklist,提升审查质量和深度。

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • 添加 pr_reviewer.num_code_suggestions: 4,增加代码建议数量
  • 添加 pr_reviewer.extra_instructions,注入审查标准:
    • [Bug](必须修复)和 [Suggestion](建议改进)分级分类
    • 四个审查维度:控制流、数据流、集成点、并发
    • 性能问题检测(N+1 查询、循环内重复计算、大对象拷贝等)
    • 要求引用具体变量名/函数名,附带修复代码块
    • 自动匹配 PR 语言(中文/英文)

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

合入后在新 PR 上验证审查效果。

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • My changes generate no new warnings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zhoujh01 zhoujh01 merged commit a1de3ad into main Mar 5, 2026
5 of 7 checks passed
@zhoujh01 zhoujh01 deleted the ci/enhance-pr-review-instructions branch March 5, 2026 12:22
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants