FIX: fixes multiple issues in the OpenViking chat functionality and unifies session ID generation logic between Python and Rust CLI implementations.#446
Conversation
…nfig
- Remove docker and aiosandbox from available backends
- Remove settings_path from SrtBackendConfig (now auto-generated in workspace)
- Update SRT settings path to workspace/sandboxes/{session}-srt-settings.json
- Update README examples to use srt backend and remove settingsPath
…nfig
- Remove docker and aiosandbox from available backends
- Remove settings_path from SrtBackendConfig (now auto-generated in workspace)
- Update SRT settings path to workspace/sandboxes/{session}-srt-settings.json
- Update README examples to use srt backend and remove settingsPath
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This reverts commit 59f4e87.
… BotProcess dataclass
- Update Python to use py-machineid library - Update Rust to use machine-uid crate - Remove unused chat_v2.rs - Move machine ID from file storage to system-provided IDs - Add fallback to "default" if system ID is unavailable
|
|
||
| ```bash | ||
| # Install VikingBot from source (in OpenViking root directory) | ||
| uv pip install -e bot/ |
There was a problem hiding this comment.
现在vikingbot还是源码安装,下个pr改成.[bot] 这样
Description
Summary
This branch fixes multiple issues in the OpenViking chat functionality and
unifies session ID generation logic between Python and Rust CLI
implementations.
Key Changes
- Implemented machine unique ID as default session ID for both Python and
Rust CLI
- Added get_or_create_machine_id() function that uses hostname or
generates a random ID
- Session ID logic is now consistent across Python and Rust
implementations
- Unified to use type="cli"
- channel_id defaults to "default"
- chat_id is now used as session_id
- Removed loguru dependency from openviking/server/routers/bot.py
- Switched to using unified logger from openviking_cli.utils.logger
- Added bot logging configuration options to server bootstrap
- Simplified log messages for sandbox and langfuse
- Removed unsupported --logs parameter from chat command
- Fixed UTF-8 issues in chat command
- Added tab indentation to Think, Calling, and Result lines in CLI output
- Removed unused handle_chat_direct function
- Added comprehensive test suite for chat commands
- Added test_all.sh script for running tests
- Added pytest configuration and test fixtures
- Removed docker/aiosandbox backends
- Simplified SRT configuration
- Added new chat_v2.rs implementation
- Added configuration module
- Simplified main.rs
- Added first release workflow
- Updated release workflow with correct working directory
Files Modified
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes