You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The arch matrix expression is overly complex and relies on operator precedence, which could lead to unexpected behavior. Consider simplifying for readability and maintainability.
The build-linux job uses ubuntu:20.04 container for both x86_64 and aarch64 runners. Verify that Ubuntu 20.04 container works correctly on Ubuntu 24.04 ARM host.
The current condition only triggers for specific Ubuntu labels, breaking support for custom Ubuntu runners (e.g., ubuntu-22.04). Revert to checking for the general 'ubuntu' substring to cover all Ubuntu-based runners, including the new ubuntu-24.04-arm.
Why: The current condition misses custom Ubuntu runners (e.g., ubuntu-22.04) by only checking specific labels. Restoring the general 'ubuntu' substring check fixes this functional regression for custom runners.
Medium
General
Simplify arch matrix condition
The arch matrix condition is overly complex and relies on fragile operator precedence. Simplify it by breaking down the logic into explicit, parenthesized checks for readability and maintainability.
Why: The original arch matrix condition is overly complex and relies on fragile operator precedence. The simplified version uses explicit ternary logic for better readability and maintainability.
Low
Restore descriptive job names
The simplified job name no longer differentiates between different OSes (e.g., macOS arm64 vs x86_64) or Python versions, making the workflow UI confusing. Restore the original descriptive naming with matrix variables.
Why: The simplified job name makes it hard to differentiate between different OSes and Python versions in the workflow UI. Restoring the original descriptive naming improves usability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes