You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR removed the check that returned a default RawDSL({"op": "and", "conds": []}) when merged was None. This could cause _build_scope_filter to return None instead of a valid filter object, potentially breaking downstream code that expects a filter.
The change removed the check that returns a default RawDSL({"op": "and", "conds": []}) when merged is None. This could cause unexpected behavior if downstream code expects a filter object rather than None. Restore the check for merged being None to maintain the original behavior.
Why: The suggestion correctly identifies that removing the None check could cause unexpected behavior in downstream code expecting a filter object instead of None, addressing a potential regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes