You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code now returns None directly from _build_scope_filter when merged is None, instead of returning a default RawDSL({"op": "and", "conds": []}). This may break callers that expect a valid filter object instead of None.
The change removes the check that ensures a valid filter is returned even when _merge_filters returns None. This may break downstream code that expects a filter object (not None). Restore the check to return an empty "and" filter when no merged filter exists.
Why: The PR removed the check that returns a valid empty filter when _merge_filters returns None, which could break downstream code expecting a filter object. Restoring this check fixes a potential regression, making this a high-impact correct suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes