Skip to content

Revert "refactor: remove agfs port configuration"#498

Merged
qin-ctx merged 1 commit intomainfrom
revert-483-remove-agfs-port
Mar 9, 2026
Merged

Revert "refactor: remove agfs port configuration"#498
qin-ctx merged 1 commit intomainfrom
revert-483-remove-agfs-port

Conversation

@Soda-Wong
Copy link
Collaborator

Reverts #483

@qin-ctx qin-ctx merged commit 164c3ed into main Mar 9, 2026
5 checks passed
@qin-ctx qin-ctx deleted the revert-483-remove-agfs-port branch March 9, 2026 13:57
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

483 - Not compliant

Non-compliant requirements:

  • 从 INSTALL.md 和 INSTALL-ZH.md 中移除 agfs port 配置示例
  • 从 install.ps1 中移除 AGFS 端口相关配置
  • 从 install.sh 中移除 AGFS 端口相关配置
  • 从 setup-helper/cli.js 中移除 AGFS 端口相关配置
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing Default Variable

Verify that DEFAULT_AGFS_PORT is defined in install.sh to avoid empty agfs_port values.

local agfs_port="${DEFAULT_AGFS_PORT}"
Missing Default Variable

Verify that DEFAULT_AGFS_PORT is defined in cli.js to avoid reference errors.

agfsPort = DEFAULT_AGFS_PORT,
Missing Default Variable

Verify that DefaultAgfsPort is defined in install.ps1 to avoid empty agfsPort values.

$agfsPort = "$DefaultAgfsPort"

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants