maintaince pr

.gitattributes

@@ -0,0 +1 @@
+./** text=auto eol=lf

.github/ISSUE_TEMPLATE/bug_report.md

@@ -26,3 +26,7 @@ Test log from the tester.
 **Hardware/Software info**
 
 List about the OS, hardware, compiler and tester.
+
+**Specifically, if the issue is reported by logic analysis, provide solution if applicable.**
+
+solution to the issue if applicable. If not, please provide the logic analysis data and your interpretation of it.

.github/workflows/clang-format.yml

@@ -3,7 +3,9 @@ name: clang-format
 on:
   pull_request:
     branches: [ "main" ]
-
+  push:
+    branches-ignore:
+      - main
 jobs:
   format:
     if: github.actor != 'github-actions[bot]'
@@ -14,6 +16,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
+          ref: ${{ github.head_ref }}
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install clang-format
@@ -30,4 +33,4 @@ jobs:
             git config user.name "GitHub Actions"
             git commit -am "Apply clang-format"
             git push
-          fi
+          fi

.github/workflows/test.yml

@@ -0,0 +1,73 @@
+name: test
+
+on:
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  build:
+    if: ${{ !endsWith(github.event.pull_request.title, 'no functional change') }}
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: true
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+        build_type: [Debug, Release]
+        c_compiler: [gcc, clang, cl]
+
+        include:
+          # Windows
+          - os: windows-latest
+            c_compiler: cl
+            cpp_compiler: cl
+          - os: windows-latest
+            c_compiler: clang
+            cpp_compiler: clang++
+          - os: windows-latest
+            c_compiler: gcc
+            cpp_compiler: g++
+
+          # Linux
+          - os: ubuntu-latest
+            c_compiler: gcc
+            cpp_compiler: g++
+          - os: ubuntu-latest
+            c_compiler: clang
+            cpp_compiler: clang++
+
+        exclude:
+          - os: ubuntu-latest
+            c_compiler: cl
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set build dir
+        id: vars
+        shell: bash
+        run: echo "dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT"
+
+      - name: Configure CMake
+        shell: bash
+        run: |
+          cmake -B "${{ steps.vars.outputs.dir }}" \
+                -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} \
+                -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} \
+                -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
+                -DSANITIZERS="address,undefined" \
+                -DDART_TESTING_TIMEOUT=0 \
+                -S "${{ github.workspace }}"
+
+      - name: Build
+        run: cmake --build ${{ steps.vars.outputs.dir }} --config ${{ matrix.build_type }}
+
+      - name: Test
+        working-directory: ${{ steps.vars.outputs.dir }}
+        shell: bash
+        run: |
+          if [[ "${{ matrix.os }}" == "windows-latest" ]]; then
+            ctest --build-config ${{ matrix.build_type }} --verbose -j 4 --timeout 0
+          else
+            ctest --verbose -j 4 --timeout 0
+          fi

.github/workflows/cmake-multi-platform.yml → .github/workflows/try_compile.yml

@@ -1,18 +1,17 @@
-name: CMake on multiple platforms
+name: Compilation
 
 on:
-  pull_request:
-    branches: [ "main" ]
+  pull_request: 
 
 jobs:
   build:
     runs-on: ${{ matrix.os }}
 
     strategy:
-      fail-fast: false
+      fail-fast: true
       matrix:
         os: [ubuntu-latest, windows-latest]
-        build_type: [Debug, Release]
+        build_type: [Debug]
         c_compiler: [gcc, clang, cl]
 
         include:
@@ -52,10 +51,6 @@ jobs:
       run: |
         CXX_FLAGS=""
         LINK_FLAGS=""
-        if [[ "${{ matrix.os }}" == "ubuntu-latest" && "${{ matrix.build_type }}" == "Debug" ]]; then
-          CXX_FLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g"
-          LINK_FLAGS="-fsanitize=address,undefined"
-        fi
 
         cmake -B "${{ steps.vars.outputs.dir }}" \
               -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} \
@@ -67,13 +62,3 @@ jobs:
 
     - name: Build
       run: cmake --build ${{ steps.vars.outputs.dir }} --config ${{ matrix.build_type }}
-
-    - name: Test
-      working-directory: ${{ steps.vars.outputs.dir }}
-      shell: bash
-      run: |
-        if [[ "${{ matrix.os }}" == "windows-latest" ]]; then
-          ctest --build-config ${{ matrix.build_type }} --verbose -j 4
-        else
-          ctest --verbose -j 4
-        fi

.gitignore

@@ -1,18 +1,22 @@
-out/
-build/
-.vs/
+# Ignore everything
+*
+
+# Allow source and essential files
 !*.cpp
 !*.h
+!CMakeLists.txt
 !README.md
 !LICENSE
-!CMakeLists.txt
 !.gitignore
 !.gitattributes
-CMakePresets.json
-CMakeSettings.json
-*.s
-.vscode
-.cache
-deps/*
-!deps/
-*
+!.github/**
+!.github/
+# Ignore build/editor junk
+build/
+out/
+.vs/
+.vscode/
+.cache/
+cmake-*/
+# Ignore asm outputs
+*.s

CMakeLists.txt

@@ -3,7 +3,7 @@ project(chesslib LANGUAGES CXX)
 
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
-option(ENABLE_COVERAGE "Enable coverage reporting" OFF)
+
 # --- Compiler tuning ---
 if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   if (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
@@ -32,10 +32,6 @@ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
   add_compile_options(/constexpr:steps2000000000 /constexpr:depth1024 ${ARCH_FLAG})
 endif()
 
-if(ENABLE_COVERAGE)
-    set(CMAKE_BUILD_TYPE Debug CACHE STRING "" FORCE)
-    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION OFF)
-endif()
 add_compile_definitions(GENERATE_AT_RUNTIME)
 if(CMAKE_BUILD_TYPE MATCHES "Debug")
   add_compile_definitions(_DEBUG)
@@ -48,125 +44,32 @@ set(SOURCES
 add_library(chesslib STATIC ${SOURCES})
 target_include_directories(chesslib PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 # --- Enable CTest integration ---
-enable_testing()
-include(FetchContent)
-FetchContent_Declare(
-    doctest
-    GIT_REPOSITORY https://github.com/doctest/doctest.git
-    GIT_TAG v2.4.12
-)
-FetchContent_MakeAvailable(doctest)
-# --- Test executable ---
-add_executable(test_chess
-    tests.cpp
-)
-add_executable(NonImportantTests
-    non_core_tests.cpp
-)
-target_link_libraries(test_chess PRIVATE chesslib)
-target_include_directories(test_chess PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${doctest_SOURCE_DIR})
-target_link_libraries(NonImportantTests PRIVATE chesslib)
-target_include_directories(NonImportantTests PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${doctest_SOURCE_DIR})
-add_test(NAME test_core COMMAND test_chess)
-add_test(NAME api_tests COMMAND NonImportantTests)
-if(ENABLE_COVERAGE)
-
-    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-        foreach(t chesslib test_chess NonImportantTests)
-            target_compile_options(${t} PRIVATE
-                --coverage
-                -O0
-            )
-            target_link_options(${t} PRIVATE
-                --coverage
-            )
-        endforeach()
-
-        find_program(GCOVR gcovr REQUIRED)
-
-        add_custom_target(coverage
-            COMMAND ${CMAKE_COMMAND} -E make_directory coverage
-            COMMAND ${CMAKE_CTEST_COMMAND}
-            COMMAND ${GCOVR}
-                -r ${CMAKE_SOURCE_DIR}
-                --html
-                --html-details
-                -o coverage/index.html
-                --exclude-directories tests
-            WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-            COMMENT "Generating GCC coverage report"
-        )
-    elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-        foreach(t chesslib test_chess NonImportantTests)
-            target_compile_options(${t} PRIVATE
-                -fprofile-instr-generate
-                -fcoverage-mapping
-                -O0
-            )
-            target_link_options(${t} PRIVATE
-                -fprofile-instr-generate
-            )
-        endforeach()
-
-        if(WIN32)
-
-            find_program(LLVM_PROFDATA llvm-profdata REQUIRED)
-            find_program(LLVM_COV llvm-cov REQUIRED)
-
-            add_custom_target(coverage
-                COMMAND ${CMAKE_COMMAND} -E make_directory coverage
-
-                COMMAND ${CMAKE_COMMAND} -E env
-                    LLVM_PROFILE_FILE=coverage/coverage.profraw
-                    CTEST_PARALLEL_LEVEL=1
-                    ${CMAKE_CTEST_COMMAND}
-
-                COMMAND ${LLVM_PROFDATA} merge
-                    -sparse
-                    coverage/coverage.profraw
-                    -o coverage/coverage.profdata
-
-                COMMAND ${LLVM_COV} show
-                    $<TARGET_FILE:test_chess>
-                    $<TARGET_FILE:NonImportantTests>
-                    -instr-profile=coverage/coverage.profdata
-                    -format=html
-                    -output-dir=coverage
-                    -ignore-filename-regex="tests|doctest"
-                    -Xdemangler=llvm-cxxfilt
-
-                WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-                COMMENT "Generating Clang coverage report (Windows)"
-            )
-        else()
-
-            find_program(LLVM_PROFDATA llvm-profdata REQUIRED)
-            find_program(LLVM_COV llvm-cov REQUIRED)
-
-            add_custom_target(coverage
-                COMMAND ${CMAKE_COMMAND} -E make_directory coverage
-
-                COMMAND ${CMAKE_COMMAND} -E env
-                    LLVM_PROFILE_FILE=coverage/%m.profraw
-                    ${CMAKE_CTEST_COMMAND}
-
-                COMMAND ${LLVM_PROFDATA} merge
-                    -sparse
-                    coverage
-                    -o coverage/coverage.profdata
-
-                COMMAND ${LLVM_COV} show
-                    $<TARGET_FILE:test_chess>
-                    $<TARGET_FILE:NonImportantTests>
-                    -instr-profile=coverage/coverage.profdata
-                    -format=html
-                    -output-dir=coverage
-                    -ignore-filename-regex="tests|doctest"
-                    -Xdemangler=c++filt
-
-                WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-                COMMENT "Generating Clang coverage report"
-            )
+include(CTest)
+
+if(BUILD_TESTING)
+    include(FetchContent)
+    FetchContent_Declare(
+        doctest
+        GIT_REPOSITORY https://github.com/doctest/doctest.git
+        GIT_TAG v2.4.12
+    )
+    FetchContent_MakeAvailable(doctest)
+
+    # --- Test executable ---
+    add_executable(test_chess tests.cpp)
+    add_executable(NonImportantTests non_core_tests.cpp)
+
+    target_link_libraries(test_chess PRIVATE chesslib doctest::doctest)
+    target_link_libraries(NonImportantTests PRIVATE chesslib doctest::doctest)
+
+    add_test(NAME test_core COMMAND test_chess)
+    add_test(NAME api_tests COMMAND NonImportantTests)
+    if (UNIX AND CMAKE_BUILD_TYPE MATCHES "Debug")
+        set(SANITIZERS "" CACHE STRING "sanitizers such as undefined,address")
+
+        if (NOT "${SANITIZERS}" STREQUAL "")
+            add_compile_options(-fsanitize=${SANITIZERS} -fno-omit-frame-pointer)
+            add_link_options(-fsanitize=${SANITIZERS})
         endif()
     endif()
 

attacks.h

@@ -144,9 +144,7 @@ extern const std::array<Bitboard, 0x1480> BishopAttacks;
  * @param b
  * @return
  */
-template <Direction direction> [[nodiscard]] static constexpr Bitboard shift(const Bitboard b) {
-    ASSUME(direction == NORTH || direction == EAST || direction == SOUTH || direction == WEST || direction == NORTH_EAST ||
-           direction == SOUTH_EAST || direction == SOUTH_WEST || direction == NORTH_WEST);
+[[nodiscard]] static constexpr Bitboard shift(const Bitboard b, Direction direction) {
     switch (direction) {
     case Direction::NORTH:
         return b << 8;
@@ -166,8 +164,16 @@ template <Direction direction> [[nodiscard]] static constexpr Bitboard shift(con
         return (b & ~MASK_FILE[7]) >> 7;
     default:
         UNREACHABLE();
+        return 0;
     }
 }
+/**
+ * @brief  Shifts a bitboard in a given direction
+ * @tparam direction
+ * @param b
+ * @return
+ */
+template <Direction direction> [[nodiscard]] static constexpr Bitboard shift(const Bitboard b) { return shift(b, direction); }
 
 /**
  * @brief