Use ENOMEM return and add goto out on AAD error with linuxkm#9971
Open
JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
Open
Use ENOMEM return and add goto out on AAD error with linuxkm#9971JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns kernel-module error handling with platform conventions by returning -ENOMEM on allocation failures and ensuring early exit/cleanup when AAD processing fails.
Changes:
- Replace
-MEMORY_Ewith-ENOMEMfor allocation failures in Linux KM AES init paths. - Add
gototo a common exit path on AAD error in GCM work handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| linuxkm/lkcapi_aes_glue.c | Switch allocation-failure returns to Linux-standard -ENOMEM. |
| bsdkm/wolfkmod.c | Jump to shared cleanup/exit path when AAD setup reports an error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Retest this please Jenkins. Windows test connection failure. |
Contributor
Author
|
Retest this please Jenkins. Multi-test failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f-631 & f-669