Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dbcf64b37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!Base64EncodedRegex.test(header)) { | ||
| let jsonStr: string | ||
| try { | ||
| jsonStr = new TextDecoder().decode(base64.decode(header)) |
There was a problem hiding this comment.
parseAgentkitHeader now decodes with @scure/base, which rejects Base64 strings that omit trailing = padding. The previous implementation (Base64EncodedRegex + safeBase64Decode) accepted those headers, and unpadded Base64 is common in non-JS clients and proxies that normalize header values. This change causes valid previously-supported agentkit headers to fail with Invalid agentkit header: not valid base64, breaking interoperability for existing senders unless they add padding explicitly.
Useful? React with 👍 / 👎.
2 participants
No description provided.