Merged
Conversation
we want to call step again if there's remaining data. pos + toWrite is what we consumed from this network frame to complete the encrypted frame. so if it's less than the total network frame (data.length), then call step again.
fix reading encrypted frames that don't line up with network frames
* events is actually called ev * there is no bonjour field
HAP spec allows shortening UUIDs if they're well known Apple ones doing this drastically reduces response sizes
make sure we bind the HTTP server to the same address that we told Bonjour to advertise. otherwise we might end up listening on some rando interface that may not actually be able to accept connections
Some streamlining
fix a pairing issue
yfre
pushed a commit
that referenced
this pull request
Dec 28, 2020
* fix thermostat for io13. make temprature unit changeable * add subscribe/unsubscribe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.