Skip to content

Use correct precision to compare#13378

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:fix-comparison
Aug 13, 2024
Merged

Use correct precision to compare#13378
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:fix-comparison

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Aug 13, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Aug 13, 2024

@wiechula I am pretty sure the current test is only working for the case the results are bit to bit equal. The epsilon is clearly too small for even one bit differences if the exponent is not 1.

I copied the equality from https://en.cppreference.com/w/cpp/types/numeric_limits/epsilon and with the new function the test works also on ARM, someone should crosscheck, though.

@ktf ktf merged commit ab9bfac into AliceO2Group:dev Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant