Skip to content

Use correct precision to compare #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Aug 13, 2024
Merged

Use correct precision to compare #13378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions Detectors/TPC/base/test/testTPCCalDet.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,45 @@
namespace o2::tpc
{

//templated euqality check
// for integer one would need a specialisation to check for == instead of <
// templated euqality check
// for integer one would need a specialisation to check for == instead of <
template <typename T>
bool isEqualAbs(T x, T y, int n = 1)
{
// Since `epsilon()` is the gap size (ULP, unit in the last place)
// of floating-point numbers in interval [1, 2), we can scale it to
// the gap size in interval [2^e, 2^{e+1}), where `e` is the exponent
// of `x` and `y`.

// If `x` and `y` have different gap sizes (which means they have
// different exponents), we take the smaller one. Taking the bigger
// one is also reasonable, I guess.
const T m = std::min(std::fabs(x), std::fabs(y));

// Subnormal numbers have fixed exponent, which is `min_exponent - 1`.
const int exp = m < std::numeric_limits<T>::min()
? std::numeric_limits<T>::min_exponent - 1
: std::ilogb(m);

// We consider `x` and `y` equal if the difference between them is
// within `n` ULPs.
return std::fabs(x - y) <= n * std::ldexp(std::numeric_limits<T>::epsilon(), exp);
}

template <typename T>
requires(std::integral<T>)
bool isEqualAbs(T val1, T val2)
{
return std::abs(val1 - val2) < std::numeric_limits<T>::epsilon();
return val1 == val2;
}

BOOST_AUTO_TEST_CASE(CalArray_ROOTIO)
{
//CalROC roc(PadSubset::ROC, 10);
// CalROC roc(PadSubset::ROC, 10);
CalArray<unsigned> roc(PadSubset::ROC, 10);

int iter = 0;
//unsigned iter=0;
// unsigned iter=0;
for (auto& val : roc.getData()) {
val = iter++;
}
Expand All @@ -51,7 +75,7 @@ BOOST_AUTO_TEST_CASE(CalArray_ROOTIO)
f->WriteObject(&roc, "roc");
delete f;

//CalROC *rocRead = nullptr;
// CalROC *rocRead = nullptr;
CalArray<unsigned>* rocRead = nullptr;
f = TFile::Open("CalArray_ROOTIO.root");
f->GetObject("roc", rocRead);
Expand Down Expand Up @@ -201,7 +225,7 @@ BOOST_AUTO_TEST_CASE(CalDet_Arithmetics)
//
// ===| test operators with simple numbers |==================================
//
const float number = 0.2;
const float number = 0.2f;
bool isEqual = true;

// + operator
Expand Down Expand Up @@ -320,4 +344,4 @@ BOOST_AUTO_TEST_CASE(CalDetTypeTest)
BOOST_CHECK(testDict == true);
}

} // namespace o2
} // namespace o2::tpc