sdl_glimp: also recreate window on resolution change#657
Merged
Conversation
Window resolution can also change without calling vid_restart: it happens when the window failed to be created and a lower resolution is tried instead.
slipher
reviewed
Jul 26, 2022
illwieckz
force-pushed
the
illwieckz/resolution
branch
from
9a62e6e to
3a2440c
Compare
DolceTriade
approved these changes
Jul 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window resolution can also change without calling
vid_restart: it happens when the window failed to be created and a lower resolution is tried instead.This replaces:
This is a fixup for:
Not recreating the window when the fallback resolution is tried because the context creation failed was a regression.