Skip to content

sdl_glimp: also recreate window on resolution change #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illwieckz merged 1 commit into from
Jul 27, 2022
Merged

sdl_glimp: also recreate window on resolution change #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/engine/sys/sdl_glimp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,20 +785,27 @@ static bool GLimp_CreateContext( const glConfiguration &configuration )

/* GLimp_DestroyWindowIfExists checks if window exists before
destroying it so we can call GLimp_RecreateWindowWhenChange even
if no window is created yet.

It is assumed width, height and other things like that are unchanged,
given vid_restart is called when changing those and then destroying
the window before calling this. */
if no window is created yet. */
static bool GLimp_RecreateWindowWhenChange( const bool fullscreen, const bool bordered, const glConfiguration &configuration )
{
/* Those values doen't contribute to anything
when the window isn't created yet. */
static bool currentFullscreen = false;
static bool currentBordered = false;
static int currentWidth = 0;
static int currentHeight = 0;
static glConfiguration currentConfiguration = {};

if ( window == nullptr
/* We don't care if comparing default values
is wrong when the window isn't created yet as
the first thing we do is to overwrite them. */
|| glConfig.vidWidth != currentWidth
|| glConfig.vidHeight != currentHeight
|| configuration != currentConfiguration )
{
currentWidth = glConfig.vidWidth;
currentHeight = glConfig.vidHeight;
currentConfiguration = configuration;

GLimp_DestroyWindowIfExists();
Expand Down