Skip to content

Issue 39848: List designer "export and print" checkbox not properly hiding print button on list grid #1033

Merged
cnathe merged 1 commit intodevelopfrom
fb_listPrintButton39848
Apr 6, 2020
Merged

Issue 39848: List designer "export and print" checkbox not properly hiding print button on list grid #1033
cnathe merged 1 commit intodevelopfrom
fb_listPrintButton39848

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented Apr 6, 2020

Rationale

See issue https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=39848
For a list in LKS, there is a list designer option to hide/show the "export and print" buttons from the list grid. The export button was properly respecting this setting, but the print button was not. This looks to be a regression from back when we did the updated UX rollout from a couple years ago and unrelated to the recent changes we've made to the List Designer.

Changes

  • Update to QueryView.setupDataView to add check for showExportButtons() when adding createPrintButton()

- the export button was being hidden as expected but not the print button
- looks to be a regression from back when we did the updated UX rollout from a couple years ago
@cnathe cnathe changed the title Issue 39848: List designer "export and print" checkbox not respected Issue 39848: List designer "export and print" checkbox not properly hiding print button on list grid Apr 6, 2020
@cnathe cnathe merged commit 9c5174a into develop Apr 6, 2020
@cnathe cnathe deleted the fb_listPrintButton39848 branch April 6, 2020 18:28
labkey-matthewb added a commit that referenced this pull request Apr 3, 2026
@labkey-matthewb labkey-matthewb mentioned this pull request Apr 3, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants