Skip to content

Issue 39848: List designer "export and print" checkbox not properly hiding print button on list grid #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 1 commit into from
Apr 6, 2020
Merged

Issue 39848: List designer "export and print" checkbox not properly hiding print button on list grid #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/src/org/labkey/api/query/QueryView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,8 +2222,9 @@ protected void setupDataView(DataView ret)
// TODO: Until the "More" menu is dynamically populated the "Print" button has been moved back to the bar.
// Print button is rendered separately to respect ordering -- we want it rendering after all custom buttons
// added by overrides of populateButtonBar().
bb.add(createPrintButton());
// bar.add(populateMoreMenu());
// bar.add(populateMoreMenu());
if (showExportButtons())
bb.add(createPrintButton());
}
rgn.setButtonBar(bb);

Expand Down