listostypes: Fixes #2529 return boolean than string in response#2632
Merged
yadvr merged 1 commit intoapache:4.11from May 9, 2018
Merged
listostypes: Fixes #2529 return boolean than string in response#2632yadvr merged 1 commit intoapache:4.11from
yadvr merged 1 commit intoapache:4.11from
Conversation
This returns the boolean value of the `isuserdefined` key than converting it to string. Fixes apache#2529. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
I checked no smoke/component test consumes this API key, travis and packaging tests are enough to validate this change. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2037 |
Member
|
LGTM |
resmo
approved these changes
May 9, 2018
Member
Author
|
Merging this based on Travis smoke tests and reviews. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This returns the boolean value of the
isuserdefinedkey thanconverting it to string. Fixes #2529.
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing