Fix os type response isuserdefined

[isupersky]

Description

This PR resolves issue #8127. Changing the datatype of isUserDefined of class GuestOSResponse from String to Boolean.

Fixes: #8127

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[shwstppr]

@isupersky can you please properly rebase your PR branch with 4.18 branch?

[codecov]

Codecov Report

Merging #8128 (4065ef3) into main (99ded81) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8128      +/-   ##
============================================
+ Coverage     29.22%   29.25%   +0.02%     
- Complexity    30490    30520      +30     
============================================
  Files          5101     5101              
  Lines        358817   358817              
  Branches      52362    52362              
============================================
+ Hits         104861   104958      +97     
+ Misses       239558   239458     -100     
- Partials      14398    14401       +3     

Flag	Coverage Δ
simulator-marvin-tests	25.22% <100.00%> (+0.03%)	⬆️
uitests	4.84% <ø> (ø)
unit-tests	14.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...pache/cloudstack/api/response/GuestOSResponse.java	68.18% <ø> (ø)
...src/main/java/com/cloud/api/ApiResponseHelper.java	47.76% <100.00%> (ø)

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7458

[weizhouapache]

CODE LGTM

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8050)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43972 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8128-t8050-kvm-centos7.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

@weizhouapache @DaanHoogland @harikrishna-patnala @rohityadavcloud should this also go into 4.18?

[DaanHoogland]

clgtm

[DaanHoogland]

@weizhouapache @DaanHoogland @harikrishna-patnala @rohityadavcloud should this also go into 4.18?

this seems a regression @shwstppr , on 4.18 the field is already a bool.

[shwstppr]

my bad @DaanHoogland. Probably referred wrong original PR

[weizhouapache]

@weizhouapache @DaanHoogland @harikrishna-patnala @rohityadavcloud should this also go into 4.18?

this seems a regression @shwstppr , on 4.18 the field is already a bool.

ooo
It has already been fixed in #2632, and reverted in #6979

[DaanHoogland]

yes @weizhouapache ,
this asks for some kind of test (beit unit or integration)

[DaanHoogland]

tested:
without this PR

    {
      "description": "Windows XP SP3 (32-bit)",
      "fordisplay": true,
      "id": "e6561287-6db0-11ee-9ca5-1e003a000ac4",
      "isuserdefined": "false",
      "name": "Windows XP SP3 (32-bit)",
      "oscategoryid": "e64d1a63-6db0-11ee-9ca5-1e003a000ac4",
      "oscategoryname": "Windows"
    }

with

    {
      "description": "Windows XP SP3 (32-bit)",
      "fordisplay": true,
      "id": "246184aa-727c-11ee-9c7e-1e00ac0002c4",
      "isuserdefined": false,
      "name": "Windows XP SP3 (32-bit)",
      "oscategoryid": "2452d76f-727c-11ee-9c7e-1e00ac0002c4",
      "oscategoryname": "Windows"
    }

merging

[boring-cyborg]

Awesome work, congrats on your first merged pull request!