Build shared pcntl module#3
Build shared pcntl module#3jtarchie merged 1 commit intocloudfoundry:masterfrom hairmare:feature/build-pcntl-extension
Conversation
|
PInging @flavorjones or @jtarchie. Could you look into this? |
|
Pinging @dmikusa-pivotal for thoughts. |
|
Don't see any reason not to include this extension, as long as it's compiled as a shared library. From what I can tell, it looks like this PR should do that. I didn't build to confirm though. |
|
Everything builds fine and tests pass with it. |
|
@hairmare can you please confirm that you've either signed the personal CLA or that you're covered by (it looks like) Swisscom's CLA? Our cfdreddbot missed this PR and this repository, and I'm having trouble manually figuring out if you're covered. |
|
@flavorjones I'm covered by the Swisscom CLA. Thanks, I was already wondering why @cfdreddbot wasn't pesky ;) |
|
Sweet, thanks! |
|
@hairmare, the cf-binary-beta branch of the PHP buildpack supports this latest changes. It would be awesome to get your feedback that they work for you. Thanks. |
|
@jtarchie I just checked and everything looks ok on the cf-binary-beta branch. |
|
Awesome, thanks so much for the contributions, @hairmare! |
- (#1) output: fix Commit() using shell || operator with Runner; now runs git diff --cached --quiet first and only commits when changes are staged - (#2) fetch: add 10-minute timeout to HTTP client (was http.DefaultClient) - (#3) archive: remove unused globs parameter from Pack - (#4) simple: fix YarnRecipe mutating src.Version; use local var and set outData.Version explicitly so findIntermediateArtifact can locate the file - (#5) nginx: fix misleading comment claiming custom args are prepended - (#6) nginx: use slices.Concat instead of append onto package-level slice - (#7) passthrough: extract moveFile into internal/fileutil.MoveFile with cross-device (EXDEV) fallback; use it in both passthrough.go and main.go - (#8) go_recipe: move bootstrap URL from hardcoded constant into stack YAML (go.bootstrap_url) following the same pattern as jruby.jdk_url
4 participants
This builds
pcntlas a shared module.As far as I could tell the module ends up in the php tarball as intended.
Due to the fact that
pcntlhas been part of php for ages I do not suspect this to be any different in the various php versions supported by the php buildpack.The
pcntlmodule has been requested in both cloudfoundry/php-buildpack#82 and cloudfoundry/php-buildpack#78.