Skip to content

Build shared readline#6

Merged
jtarchie merged 1 commit intocloudfoundry:masterfrom
hairmare:feature/readline-ext-as-shared-module
Aug 12, 2015
Merged

Build shared readline#6
jtarchie merged 1 commit intocloudfoundry:masterfrom
hairmare:feature/readline-ext-as-shared-module

Conversation

@hairmare
Copy link
Contributor

I'm trying to do a proof of concept drupal 8 install the composer way from this repo and am finding it requires ext-readline.

Personally, I want to use it so i can run database setup routines for my cloudy drupal instance by pushing a --no-route instance that connects to the same service I'll use on the routed instance.

I could also see myself executing things like drupals cron jobs by regularly scheduling such a routeless machine to spin up an instance.

edit: Link to readline docs on php.net.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/99436586.

@flavorjones
Copy link
Contributor

This seems entirely reasonable. I'll update the tracker story with an additional task to add a test to BRATs to exercise readline.

@jtarchie
Copy link
Contributor

jtarchie commented Aug 5, 2015

@hairmare you are unable to run terminal apps from Cloud Foundry. Readline is used for apps that require user terminal input (eg [Y/n]). You won't be able to run this scripts even if we added ext-readline.

@flavorjones because of the limitation of not being able to type characters into a terminal, we won't be able to write a BRATs for this. We'd just be able to see that the extensions loaded.

@hairmare
Copy link
Contributor Author

hairmare commented Aug 6, 2015

@jtarchie I know that I won't be able to directly use readline. Having the module is more a case of it being required by some of dependencies I want to install using composer.

I expect apps that require this to check if $TERM is interactive and run in non interactive mode on cf.

I think only checking to see if it's loaded in BRATs would suffice. My use case is being able to install things like drupal-8 using composer and such things generally like to depend on readline but usually also work in non interactive mode.

jtarchie added a commit that referenced this pull request Aug 12, 2015
@jtarchie jtarchie merged commit 85165e0 into cloudfoundry:master Aug 12, 2015
@hairmare hairmare deleted the feature/readline-ext-as-shared-module branch August 12, 2015 14:55
@flavorjones
Copy link
Contributor

This should be in php-buildpack v4.1.0, see https://www.pivotaltracker.com/story/show/102019942 for status.

@hairmare
Copy link
Contributor Author

Thanks for the update. I can confirm this works.

While drupal-8 still has a issues with being run on cloudfoundry this does make things alot easier to get started on hacking.

ramonskie added a commit that referenced this pull request Feb 27, 2026
- (#1) output: fix Commit() using shell || operator with Runner; now runs
  git diff --cached --quiet first and only commits when changes are staged
- (#2) fetch: add 10-minute timeout to HTTP client (was http.DefaultClient)
- (#3) archive: remove unused globs parameter from Pack
- (#4) simple: fix YarnRecipe mutating src.Version; use local var and set
  outData.Version explicitly so findIntermediateArtifact can locate the file
- (#5) nginx: fix misleading comment claiming custom args are prepended
- (#6) nginx: use slices.Concat instead of append onto package-level slice
- (#7) passthrough: extract moveFile into internal/fileutil.MoveFile with
  cross-device (EXDEV) fallback; use it in both passthrough.go and main.go
- (#8) go_recipe: move bootstrap URL from hardcoded constant into stack YAML
  (go.bootstrap_url) following the same pattern as jruby.jdk_url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants