Bigtable 12. Implement SampleRowKeys by igorbernstein2 · Pull Request #2913 · googleapis/google-cloud-java

igorbernstein2 · 2018-02-15T21:24:15Z

Implements the SampleRowKeys api method:

convert table ids into SampleRowKeyRequests
converts streaming SampleRowKeyResponses into a spooled List of KeyOffsets

This has been reviewed by @kevinsi4508 and is ready for review by the veneer team.

...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallable.java

+class SampleRowKeysCallable extends UnaryCallable<String, List<KeyOffset>> {
+  private final RequestContext requestContext;
+  private final UnaryCallable<
+          com.google.bigtable.v2.SampleRowKeysRequest, List<SampleRowKeysResponse>>


...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

+    baseSettingsBuilder
+        .sampleRowKeysSettings()
+        .setSimpleTimeoutNoRetries(
+            baseSettingsBuilder.sampleRowKeysSettings().getRetrySettings().getTotalTimeout())


...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

-        throw new UnsupportedOperationException("todo");
-      }
-    };
+    UnaryCallable<SampleRowKeysRequest, List<SampleRowKeysResponse>> spooling =


...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallable.java

+  private final UnaryCallable<SampleRowKeysRequest, List<SampleRowKeysResponse>> inner;
+
+  SampleRowKeysCallable(
+      UnaryCallable<SampleRowKeysRequest, List<SampleRowKeysResponse>> inner,


...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallable.java

+        rawResponse,
+        new ApiFunction<List<SampleRowKeysResponse>, List<KeyOffset>>() {
+          @Override
+          public List<KeyOffset> apply(List<SampleRowKeysResponse> responses) {


...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallable.java

+        });
+  }
+
+  private List<KeyOffset> convert(List<SampleRowKeysResponse> response) {


...bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallableTest.java

+
+  @Test
+  public void responseCorrectlyTransformed()
+      throws ExecutionException, InterruptedException, TimeoutException {


...bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/SampleRowKeysCallableTest.java

+      actualError = e.getCause();
+    } catch (Throwable t) {
+      actualError = t;
+    }


igorbernstein2 · 2018-02-16T13:55:10Z

Thanks for reviewing!

igorbernstein2 · 2018-02-16T13:56:00Z

@pongad this is ready for veneer team review

kevinsi4508 · 2018-02-16T14:19:51Z

LGTM

Implements the SampleRowKeys api method: - convert table ids into SampleRowKeyRequests - converts streaming SampleRowKeyResponses into a spooled List of KeyOffsets

* chore: check return status from maven * update workflow * verify json content * sort and tail * sed * verify returned version

Adds support for setting and getting the BigQuery v2 API Dataset property `storageBillingModel`, to allow end users to set the billing model depending on their use case. When no billing model is provided, the existing behavior (use the default billing model) continues.

* chore: check return status from maven * update workflow * verify json content * sort and tail * sed * verify returned version

igorbernstein2 requested a review from pongad as a code owner February 15, 2018 21:24

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2018

kevinsi4508 reviewed Feb 16, 2018

View reviewed changes

igorbernstein2 added 8 commits February 21, 2018 18:18

Bigtable 12. Implement SampleRowKeys

c907dcf

Implements the SampleRowKeys api method: - convert table ids into SampleRowKeyRequests - converts streaming SampleRowKeyResponses into a spooled List of KeyOffsets

codacy fixes

98ed0e5

static import truth

1d47bfd

one more codacy fix

3aa1951

improve disable retries code

6047a3a

fix imports

7199a84

address feedback

df70853

rename wrappers package

c5b06fb

igorbernstein2 force-pushed the 12-impl-sample-row-keys branch from 7d5eee4 to c5b06fb Compare February 21, 2018 23:20

pongad merged commit 1fc5c1b into googleapis:master Feb 23, 2018

igorbernstein2 deleted the 12-impl-sample-row-keys branch March 1, 2018 02:11

chingor13 pushed a commit that referenced this pull request Feb 20, 2026

chore: check return json from maven (#2913)

4f34881

* chore: check return status from maven * update workflow * verify json content * sort and tail * sed * verify returned version

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

chore: check return json from maven (#2913)

3f88564

* chore: check return status from maven * update workflow * verify json content * sort and tail * sed * verify returned version

chingor13 pushed a commit that referenced this pull request Mar 24, 2026

deps: update dependency org.json:json to v20240205 (#2913)

98fa243

Conversation

igorbernstein2 commented Feb 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Feb 16, 2018

Uh oh!

igorbernstein2 commented Feb 16, 2018

Uh oh!

kevinsi4508 commented Feb 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

igorbernstein2 commented Feb 15, 2018 •

edited

Loading