Fix bug in panorama pipeline when using dpmsolver scheduler#3499
Merged
sayakpaul merged 1 commit intohuggingface:mainfrom May 23, 2023
Merged
Fix bug in panorama pipeline when using dpmsolver scheduler#3499sayakpaul merged 1 commit intohuggingface:mainfrom
sayakpaul merged 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
@sayakpaul can you take a look for Panorama pipeline? |
sayakpaul
approved these changes
May 23, 2023
Member
sayakpaul
left a comment
There was a problem hiding this comment.
Great catch! And thanks for fixing!
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ace#3499) fix panorama pipeline with dpmsolver scheduler
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ace#3499) fix panorama pipeline with dpmsolver scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #3494
In dpmsolver scheduler,
self.model_outputsis used to save diffusion model output in previous and current timestep, and calculateprev_sample.diffusers/src/diffusers/schedulers/scheduling_dpmsolver_multistep.py
Lines 634 to 659 in 49ad61c
However, since we crop panorama image into several blocks and use
scheduler.stepin loop,self.model_outputsbecame outputs in previous and current blocks.As a result, when using dpmsolver scheduler in PanoramaPipeline, we should collect rematch
self.model_outputsin each block to right order to generate normal image.test code
Before
After