Fix panorama to support all schedulers#3546
Merged
sayakpaul merged 8 commits intohuggingface:mainfrom May 24, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Super nice PR! Good job @Isotr0py . @sayakpaul I'll let you review this one |
sayakpaul
approved these changes
May 24, 2023
Member
sayakpaul
left a comment
There was a problem hiding this comment.
Nice, this is an elegant solution to deal with stateful schedulers like PNDM!
Can we also fix this test case then?
Member
|
Also Cc: @omerbt |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* refactor blocks init * refactor blocks loop * remove unused function and warnings * fix scheduler update location * reformat code * reformat code again * fix PNDM test case * reformat pndm test case
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* refactor blocks init * refactor blocks loop * remove unused function and warnings * fix scheduler update location * reformat code * reformat code again * fix PNDM test case * reformat pndm test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PNDMSchedulerfor panorama pipeline.Similar to #3499, make all schedulers sync with blocks sampling. This can solve most of the issues about failed images generation in panorama pipeline.
Test code
Results
PNDMScheduler
UniPCMultistepScheduler
KDPM2DiscreteScheduler
DEISMultistepScheduler