[schedulers] hanlde dtype in add_noise#767
Merged
patil-suraj merged 4 commits intomainfrom Oct 7, 2022
Merged
Conversation
patil-suraj
requested review from
NouamaneTazi,
anton-l,
patrickvonplaten and
pcuenca
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
@patil-suraj should i add tests for fp16 schedulers? |
NouamaneTazi
reviewed
Oct 7, 2022
NouamaneTazi
reviewed
Oct 7, 2022
Member
There was a problem hiding this comment.
I believe that
if self.alphas_cumprod.dtype != original_samples.dtype:
self.alphas_cumprod = self.alphas_cumprod.to(original_samples.dtype)is equivalent to just doing
self.alphas_cumprod = self.alphas_cumprod.to(original_samples.dtype)Same for device. And that could cut off the lines of code quite a bit
Contributor
Author
|
Removed the if as suggested by @NouamaneTazi ! The |
Member
According to this comment it may have a penalty https://github.com/huggingface/diffusers/pull/511/files#r987896215. Is there any way we can now for sure? |
patrickvonplaten
pushed a commit
that referenced
this pull request
Oct 11, 2022
* handle dtype in vae and image2image pipeline * handle dtype in add noise * don't modify vae and pipeline * remove the if
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* handle dtype in vae and image2image pipeline * handle dtype in add noise * don't modify vae and pipeline * remove the if
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* handle dtype in vae and image2image pipeline * handle dtype in add noise * don't modify vae and pipeline * remove the if
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the
alphas/sigmashave the samedtypeas the input samples.