[img2img, inpainting] fix fp16 inference#769
Merged
patil-suraj merged 9 commits intomainfrom Oct 7, 2022
Merged
Conversation
patil-suraj
requested review from
NouamaneTazi,
anton-l,
patrickvonplaten and
pcuenca
|
The documentation is not available anymore as the PR was closed or merged. |
pcuenca
reviewed
Oct 7, 2022
NouamaneTazi
reviewed
Oct 7, 2022
Member
NouamaneTazi
left a comment
NouamaneTazi
left a comment
There was a problem hiding this comment.
The changes I suggested seem to be already in #767. But I added them to make sure they stay nonetheless
src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py
Show resolved
Hide resolved
src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_img2img.py
Show resolved
Hide resolved
Contributor
|
Code looks good to me! If code works for @pcuenca then good to merge for me :-) |
Member
|
Tests look good too. Thanks a lot! |
patrickvonplaten
pushed a commit
that referenced
this pull request
Oct 11, 2022
* handle dtype in vae and image2image pipeline * fix inpaint in fp16 * dtype should be handled in add_noise * style * address review comments * add simple fast tests to check fp16 * fix test name * put mask in fp16
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* handle dtype in vae and image2image pipeline * fix inpaint in fp16 * dtype should be handled in add_noise * style * address review comments * add simple fast tests to check fp16 * fix test name * put mask in fp16
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* handle dtype in vae and image2image pipeline * fix inpaint in fp16 * dtype should be handled in add_noise * style * address review comments * add simple fast tests to check fp16 * fix test name * put mask in fp16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inference for image2image and inpainting pipeline in
fp16.Should be merged after #767