Micro Optimizations - Round #2#608
Merged
cmb69 merged 3 commits intophp:masterfrom Jul 3, 2022
Ayesh:modernize/micro-optimizations-2
Merged
Micro Optimizations - Round #2#608cmb69 merged 3 commits intophp:masterfrom Ayesh:modernize/micro-optimizations-2
cmb69 merged 3 commits intophp:masterfrom
Ayesh:modernize/micro-optimizations-2
Conversation
`const` is quite faster because of the compile-time optimizations. Because the replaced statements are not declaring constant conditionally, it's safe to use `const` in all of these places.
kamil-tekiela
approved these changes
Jul 3, 2022
cmb69
approved these changes
Jul 3, 2022
| <?php | ||
|
|
||
| $refresh = isset($_GET['refresh']) ? true : false; | ||
| $refresh = isset($_GET['refresh']); |
Member
There was a problem hiding this comment.
Thank you for removing this nonsense! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #603, includes a few more optimizations.
constis quite faster because of the compile-time optimizations. Because the replaced statements are not declaring constant conditionally, it's safe to useconstin all of these places.Thank you.