Skip to content

Micro Optimizations - Round #2 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmb69 merged 3 commits into from
Jul 3, 2022
Merged

Micro Optimizations - Round #2 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c77a3c
.gitignore: Remove redundant entry
Ayesh Jul 3, 2022
24406af
Minor optimizations with ternary operators
Ayesh Jul 3, 2022
4b337ae
Use `const` instead of `define()` where appropriate
Ayesh Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
backend/mirror.gif
backend/mirror.png
backend/mirror.jpg
backend/mirror.jpg
backend/GeoIP.dat
.idea
.DS_Store
Expand Down
2 changes: 1 addition & 1 deletion .router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
$_SERVER["SERVER_ADDR"] = $_SERVER["HTTP_HOST"];

$filename = isset($_SERVER["PATH_INFO"]) ? $_SERVER["PATH_INFO"] : $_SERVER["SCRIPT_NAME"];
$filename = $_SERVER["PATH_INFO"] ?? $_SERVER["SCRIPT_NAME"];

if (file_exists($_SERVER["DOCUMENT_ROOT"] . $filename)) {
/* This could be an image or whatever, so don't try to compress it */
Expand Down
2 changes: 1 addition & 1 deletion images/logo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

$refresh = isset($_GET['refresh']) ? true : false;
$refresh = isset($_GET['refresh']);
Copy link
Copy Markdown
Member

@cmb69 cmb69 Jul 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing this nonsense! :)


// Be 100% sure the timezone is set
if (ini_get('date.timezone') === '' && function_exists('date_default_timezone_set')) {
Expand Down
6 changes: 3 additions & 3 deletions include/prepend.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ function myphpnet_language($langcode = FALSE)
return false;
}

define("MYPHPNET_URL_NONE", FALSE);
define("MYPHPNET_URL_FUNC", 'quickref');
define("MYPHPNET_URL_MANUAL", 'manual');
const MYPHPNET_URL_NONE = false;
const MYPHPNET_URL_FUNC = 'quickref';
const MYPHPNET_URL_MANUAL = 'manual';

// Set URL search fallback preference
function myphpnet_urlsearch($type = FALSE)
Expand Down
16 changes: 8 additions & 8 deletions include/site.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

// Define some constants, and $MIRRORS array
// Mirror type constants
define('MIRROR_DOWNLOAD', 0);
define('MIRROR_STANDARD', 1);
define('MIRROR_SPECIAL', 2);
define('MIRROR_VIRTUAL', 3);
const MIRROR_DOWNLOAD = 0;
const MIRROR_STANDARD = 1;
const MIRROR_SPECIAL = 2;
const MIRROR_VIRTUAL = 3;

// Mirror status constants
define('MIRROR_OK', 0);
define('MIRROR_NOTACTIVE', 1);
define('MIRROR_OUTDATED', 2);
define('MIRROR_DOESNOTWORK', 3);
const MIRROR_OK = 0;
const MIRROR_NOTACTIVE = 1;
const MIRROR_OUTDATED = 2;
const MIRROR_DOESNOTWORK = 3;

$MIRRORS = array(
"https://www.php.net/" => array(
Expand Down