Skip to content

IE11 compatibility#1106

Merged
Marc-Andre-Rivet merged 4 commits intodevfrom
webpack-dynamic-import-plugin
Jan 30, 2020
Merged

IE11 compatibility#1106
Marc-Andre-Rivet merged 4 commits intodevfrom
webpack-dynamic-import-plugin

Conversation

@Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Jan 30, 2020

Fix IE11 compatibility issues with the dynamic plugin that were obscured by how polyfills are applied in Dash. IE11 does not support Array.from.

The updated @plotly/webpack-dynamic-import-plugin will be release on NPM once approved / merged.

Marc-André Rivet added 2 commits January 30, 2020 13:13
Copy link
Contributor

@rpkyle rpkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...once tests pass 💃

Copy link
Contributor

@wbrgss wbrgss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 :shipit:

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit ece04d5 into dev Jan 30, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the webpack-dynamic-import-plugin branch January 30, 2020 18:27
nightsailer added a commit to o3cloud/dash that referenced this pull request Feb 23, 2020
* Add standard dash interface for location change (plotly#1094)

* feat: disable cookie access under restricted sandboxes (plotly#1080)

* IE11 compatibility (plotly#1106)

* Add `inheritAsyncDecorator` for wrapper components (plotly#1109)

* bump version, loosen version requirements

* dcc>=1.7.0, 1.7.1 was JS only

* stricten versions

* stricten table version

Co-authored-by: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Co-authored-by: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
nightsailer added a commit to o3cloud/dash that referenced this pull request Feb 23, 2020
* Add standard dash interface for location change (plotly#1094)

* feat: disable cookie access under restricted sandboxes (plotly#1080)

* IE11 compatibility (plotly#1106)

* Add `inheritAsyncDecorator` for wrapper components (plotly#1109)

* bump version, loosen version requirements

* dcc>=1.7.0, 1.7.1 was JS only

* stricten versions

* stricten table version

Co-authored-by: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Co-authored-by: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants