Skip to content

IE11 compatibility #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marc-Andre-Rivet merged 4 commits into from
Jan 30, 2020
Merged

IE11 compatibility #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
451205e
IE11 compatibility
Jan 30, 2020
f39e72a
Merge branch 'dev' into webpack-dynamic-import-plugin
Marc-Andre-Rivet Jan 30, 2020
cf422e8
typo
Jan 30, 2020
3c57d86
Merge branch 'webpack-dynamic-import-plugin' of github.com:plotly/das…
Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion @plotly/webpack-dash-dynamic-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@plotly/webpack-dash-dynamic-import",
"version": "1.1.4",
"version": "1.1.5",
"description": "Webpack Plugin for Dynamic Import in Dash",
"repository": {
"type": "git",
Expand Down
10 changes: 9 additions & 1 deletion @plotly/webpack-dash-dynamic-import/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ var getCurrentScript = function() {
if (!script) {
/* Shim for IE11 and below */
/* Do not take into account async scripts and inline scripts */
var scripts = Array.from(document.getElementsByTagName('script')).filter(function(s) { return !s.async && !s.text && !s.textContent; });

var doc_scripts = document.getElementsByTagName('script');
var scripts = [];

for (var i = 0; i < doc_scripts.length; i++) {
scripts.push(doc_scripts[i]);
}

scripts = scripts.filter(function(s) { return !s.async && !s.text && !s.textContent; });
script = scripts.slice(-1)[0];
}

Expand Down