meta tests: refactor run_pytest#15481
Merged
hauntsaninja merged 7 commits intopython:masterfrom Sep 2, 2023
Merged
Conversation
ikonst
force-pushed
the
06-20-meta_tests_refactor_run_pytest
branch
2 times, most recently
from
efaa570 to
632c88b
Compare
ikonst
force-pushed
the
06-20-meta_tests_refactor_run_pytest
branch
from
632c88b to
b481b33
Compare
ikonst
force-pushed
the
06-20-meta_tests_refactor_run_pytest
branch
from
c08848a to
f00a623
Compare
Contributor
Author
hauntsaninja
reviewed
Sep 2, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good, one nit!
mypy/test/meta/_pytest.py
Outdated
|
|
||
| test_nodeid = f"{pytest_node_prefix}::{p.name}" | ||
| extra_args = [sys.executable, "-m", "pytest", "-n", "0", "-s", *extra_args, test_nodeid] | ||
| if sys.version_info >= (3, 8): |
Collaborator
There was a problem hiding this comment.
We've dropped support for 3.7 :-)
Contributor
Author
There was a problem hiding this comment.
b0083b0 but we should maybe enable https://beta.ruff.rs/docs/rules/outdated-version-block/ and perhaps more "pyupgrade" rules? (in a separate PR)
hauntsaninja
approved these changes
Sep 2, 2023
Merged
hauntsaninja
pushed a commit
that referenced
this pull request
Sep 3, 2023
For example, this [review comment](#15481 (comment)) could've been spared with [UP036](https://beta.ruff.rs/docs/rules/outdated-version-block/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor
run_pytestout of mypy/test/meta/test_*.py.Also, prefixing the nested pytest output so it's harder to mix it up with parent pytest's: