Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This reverts commit 56a82e9.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Turns out the one UP037 exemption already came up before: @ichard26 is there an existing issue for this? |
Collaborator
There might be an issue somewhere, but honestly it seems fine to include in mypyc/mypyc#988. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
AlexWaygood
reviewed
Sep 3, 2023
| else: | ||
| module_name_str = name | ||
|
|
||
| return f"{file_read}: [{module_name_str}]: " |
Member
There was a problem hiding this comment.
What's the purpose of the change to this line?
Contributor
Author
There was a problem hiding this comment.
Before it was print("%sfoobar" % prefix), now it's print(prefix, "foobar") hence removed the space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, this review comment could've been spared with UP036.