Add type annotations to test-data/unit/plugins#16028
Merged
Conversation
Member
Author
|
It passed :) I will later add this commit to https://github.com/python/mypy/blob/master/.git-blame-ignore-revs if needed. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ikonst
reviewed
Sep 3, 2023
|
|
||
| class ClassMethodPlugin(Plugin): | ||
| def get_base_class_hook(self, fullname: str) -> Optional[Callable[[ClassDefContext], None]]: | ||
| def get_base_class_hook(self, fullname: str) -> Callable[[ClassDefContext], None] | None: |
Contributor
There was a problem hiding this comment.
Speaking of this change - I've just enabled ruff's "pyupgrade" (#16023) which should keep enforcing this, maybe change pyproject.toml to include the plugins in ruff?
Member
Author
There was a problem hiding this comment.
I will in later PRs, because right now - I don't know how to force ruff to include a subdirectory. Docs do not say much, so I will have to dig into the source code :)
ikonst
approved these changes
Sep 3, 2023
Contributor
ikonst
left a comment
ikonst
left a comment
There was a problem hiding this comment.
consider enabling ruff for the plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16027