Revert "Revert "use NewOptimizedDirectorySourceLocator""

[samsonasik]

Reverts #4845

[samsonasik]

@TomasVotruba I am looking why new PHPStan 1.10.31 cause error:

https://github.com/rectorphp/rector-src/actions/runs/5965825544/job/16184110293#step:10:19

[TomasVotruba]

Thanks 👍

Could you lock main for the last PHPStan working version? Just so we have passing build and no stress on fixing this

[samsonasik]

Ok, I will temporary lock phpstan to [1.10.30](https://github.com/phpstan/phpstan/releases/tag/1.10.30) on separate PR, and continue fixing here.

[samsonasik]

@TomasVotruba since the build is working ok now, let's try this 👍

[samsonasik]

@TomasVotruba I tested this in CodeIgniter4 project, it make consistency 1 second faster.

Also make correct apply ::class tested at:

• test: Apply ::class class constant on MigrationRunnerTest codeigniter4/CodeIgniter4#7847

I will check more if this while improve performance, on complex files in target dir, eg contains .xml file, it read unnecessary files, since it fetch files under directory instead of read only listed files in the directory.

[samsonasik]

@TomasVotruba I debugged, the OptimizedDirectorySourceLocatorFactory utilize PHPStan FileFinder that already only cover php extensions, so I guess it already cover only scan php files.

PHPStan\File\FileFinder #3115
   fileExcluder: PHPStan\File\FileExcluder #3113
   fileExtensions: array (1)
   |  0 => 'php'

so I think it already ok 👍