Skip to content

Temporary pin to phpstan 1.10.30#4847

Merged
samsonasik merged 1 commit intomainfrom
phpstan-11030
Aug 24, 2023
Merged

Temporary pin to phpstan 1.10.30#4847
samsonasik merged 1 commit intomainfrom
phpstan-11030

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@TomasVotruba here lets try.

@samsonasik samsonasik enabled auto-merge (squash) August 24, 2023 15:50
@samsonasik samsonasik merged commit dce1084 into main Aug 24, 2023
@samsonasik samsonasik deleted the phpstan-11030 branch August 24, 2023 15:51
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba the downgrade seems cause syntax error

https://github.com/rectorphp/rector-src/actions/runs/5966007434/job/16184720897#step:14:64

------------
Parse error: rector-prefixed-downgraded/vendor/rector/rector-symfony/rules/CodeQuality/Rector/BinaryOp/ResponseStatusCodeRector.php:135
    133|         return $this->literalCallLikeConstFetchReplacer->replaceArgOnPosition(
    134|             $methodCall,
  > 135|             new  (ObjectType, ), }),

I will check.

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba this is strange, the error is another error:

"System error: "Trying to replace statement (Stmt_Namespace) with      
         expression (Expr_MethodCall). Are you missing a Stmt_Expression        
         wrapper?"          

https://github.com/rectorphp/rector-src/actions/runs/5966007434/job/16185421625#step:10:21

it probably another issue in other area: eg: github memory issue or other dependency.

@TomasVotruba
Copy link
Copy Markdown
Member

Indeed. This used to happen in the past, when error was somewhere else.
Some stmts are re-printed with old stmts. Not sure where to look.

Let's try lower PHPStan version for now.

@TomasVotruba
Copy link
Copy Markdown
Member

Ha, 3rd time the charm :) seems good now 😆

@samsonasik
Copy link
Copy Markdown
Member Author

Ok, let's enable NewOptimizedDirectorySourceLocator again at #4846

@TomasVotruba
Copy link
Copy Markdown
Member

@samsonasik
Copy link
Copy Markdown
Member Author

Let's rebuild again, as everything rolled back, as last working is 6 hours ago

21f33de

@samsonasik
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants