ssl: rename SSLContext#ecdh_curves= to #groups=#900
Merged
rhenium merged 1 commit intoruby:masterfrom Jul 4, 2025
Merged
Conversation
TLS 1.3 renamed the "elliptic_curves" extension to "supported_groups" to reflect that it now covers more than just ECDH groups. OpenSSL 1.1.1 followed this change by renaming the corresponding API from SSL_CTX_set1_curves_list() to SSL_CTX_set1_groups_list(). Update ruby/openssl to use the new name, too. The current method name SSLContext#ecdh_curves= is retained as an alias for #group=.
rhenium
force-pushed
the
ky/ssl-ctx-set-groups
branch
from
7508249 to
59e9860
Compare
junaruga
reviewed
Jun 23, 2025
Member
junaruga
left a comment
junaruga
left a comment
There was a problem hiding this comment.
I reviewed this PR. Could you check my comments? Thank you!
5 tasks
Member
|
The PR looks good to me! |
Member
|
@rhenium Are you ready to merge this PR? I would like to merge this PR. |
Member
Author
|
I think It's ready. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS 1.3 renamed the
elliptic_curvesextension tosupported_groupsto reflect that it now covers more than just ECDH groups. OpenSSL 1.1.1 followed this change by renaming the corresponding API fromSSL_CTX_set1_curves_list()toSSL_CTX_set1_groups_list().Update ruby/openssl to use the new name, too. The current method name
SSLContext#ecdh_curves=is retained as an alias for#group=.Related: #894 (comment)