Rename the SSLContext#ecdh_curves= to #groups=.#901
Closed
junaruga wants to merge 1 commit intoruby:masterfrom
Closed
Rename the SSLContext#ecdh_curves= to #groups=.#901junaruga wants to merge 1 commit intoruby:masterfrom
SSLContext#ecdh_curves= to #groups=.#901junaruga wants to merge 1 commit intoruby:masterfrom
Conversation
Rename the `SSLContext#ecdh_curves=` to `#groups=`, keeping the `#ecdh_curves=` as an alias of the `#groups=` for backward compatibility. In OpenSSL version 1.1.1 `SSL_CTX_set1_curves_list` was renamed to `SSL_CTX_set1_groups_list`, keeping the `SSL_CTX_set1_curves_list` at the following commit. Because TLS 1.3 renamed the extension. openssl/openssl@de4d764 As we only support OpenSSL version 1.1.1 or later versions, it is no problem to use the `SSL_CTX_set1_groups_list`. For the document of the `ossl_sslctx_set_groups`, I referred to the following RFC 8446 TLS 1.3 Supported Groups section. https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.7
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the #894 (comment). I checked the generated rdoc document by this change. I am still keeping the
SSLContext#ecdh_curves=without deprecation in this PR. If we want to mark theSSLContext#ecdh_curves=as the deprecated, we can add the comment# <b>Deprecated in version 3.4.</b> Use #groups= instead.in the future, maybe before releasing the Ruby OpenSSL version 3.4.What do you think?
Rename the
SSLContext#ecdh_curves=to#groups=, keeping the#ecdh_curves=as an alias of the#groups=for backward compatibility.In OpenSSL version 1.1.1
SSL_CTX_set1_curves_listwas renamed toSSL_CTX_set1_groups_list, keeping theSSL_CTX_set1_curves_listat the following commit. Because TLS 1.3 renamed the extension. openssl/openssl@de4d764As we only support OpenSSL version 1.1.1 or later versions, it is no problem to use the
SSL_CTX_set1_groups_list.For the document of the
ossl_sslctx_set_groups,I referred to the following RFC 8446 TLS 1.3 Supported Groups section. https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.7