fix: Resolve Media3 binary compatibility crashes in DownloadHelper callbacks#86
Open
fix: Resolve Media3 binary compatibility crashes in DownloadHelper callbacks#86
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request updates the media3 library version from 1.7.1 to 1.8.0 and adjusts the DownloadHelper.Callback implementation in DownloadController.kt to include the new helperPrepared parameter. Feedback was provided to ensure that the helperPrepared flag is checked before interacting with the helper object, as failing to do so could result in an IllegalStateException if the helper was released during preparation.
tpstreams-android-player/src/main/java/com/tpstreams/player/download/DownloadController.kt
Outdated
Show resolved
Hide resolved
tpstreams-android-player/src/main/java/com/tpstreams/player/download/DownloadController.kt
Outdated
Show resolved
Hide resolved
tpstreams-android-player/src/main/java/com/tpstreams/player/download/DownloadController.kt
Outdated
Show resolved
Hide resolved
…ate .gitignore to ignore openspec files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractMethodErrorcrashes encountered by client apps.
onPreparedsignature required by newer versions,ensuring the player works across all current Media3 environments.