Skip to content

fix: Resolve Media3 binary compatibility crashes in DownloadHelper callbacks #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syed-tp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Resolve Media3 binary compatibility crashes in DownloadHelper callbacks #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c7c47
fix: resolve Media3 binary compatibility crashes in DownloadHelper ca…
syed-tp Apr 1, 2026
7bf4c74
fix: handle unavailable download tracks in DownloadController and upd…
syed-tp Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ espressoCore = "3.6.1"
lifecycleRuntimeKtx = "2.9.1"
appcompat = "1.7.1"
material = "1.12.0"
media3 = "1.7.1"
media3 = "1.8.0"
okhttp = "4.12.0"
coroutines = "1.10.2"
constraintlayout = "2.2.1"
Expand Down
23 changes: 20 additions & 3 deletions tpstreams-android-player/src/main/java/com/tpstreams/player/download/DownloadController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,13 @@ object DownloadController {
)

helper.prepare(object : DownloadHelper.Callback {
override fun onPrepared(helper: DownloadHelper) {
override fun onPrepared(helper: DownloadHelper, tracksInfoAvailable: Boolean) {
if (!tracksInfoAvailable) {
callback(emptyList(), emptyMap())
helper.release()
return
}

try {
val resolutions = mutableListOf<String>()
val bitrates = mutableMapOf<String, Int>()
Expand Down Expand Up @@ -285,7 +291,12 @@ object DownloadController {
)

helper.prepare(object : DownloadHelper.Callback {
override fun onPrepared(helper: DownloadHelper) {
override fun onPrepared(helper: DownloadHelper, tracksInfoAvailable: Boolean) {
if (!tracksInfoAvailable) {
helper.release()
return
}

try {
Log.d(TAG, "Download prepared for: ${mediaItem.mediaId}")
val baseRequest = helper.getDownloadRequest(mediaItem.mediaId.toByteArray())
Expand Down Expand Up @@ -453,7 +464,13 @@ object DownloadController {
)

helper.prepare(object : DownloadHelper.Callback {
override fun onPrepared(helper: DownloadHelper) {
override fun onPrepared(helper: DownloadHelper, tracksInfoAvailable: Boolean) {
if (!tracksInfoAvailable) {
onError?.invoke("No tracks available")
helper.release()
return
}

try {
val drmFormat = findDrmFormat(helper)
if (drmFormat != null) {
Expand Down