Merged
Conversation
ericonr
reviewed
Mar 20, 2020
Member
ericonr
left a comment
ericonr
left a comment
There was a problem hiding this comment.
I accidentally created a review instead of leaving a single comment. Didn't want to seem pompous, sorry. I'm not going to delete it, though, to avoid filling up the issue history.
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
q66
reviewed
Mar 21, 2020
flexibeast
force-pushed
the
musl
branch
6 times, most recently
from
5c26239 to
c8a8c9a
Compare
bobertlo
reviewed
Mar 24, 2020
bobertlo
reviewed
Mar 24, 2020
bobertlo
reviewed
Mar 24, 2020
src/config/musl.md
Outdated
|
|
||
| Create a directory that will contain the chroot, and install a base system in it | ||
| via the `base-voidstrap` package. If network access is required, copy | ||
| `/etc/resolv.conf` and `/etc/hosts` into the chroot. |
Contributor
There was a problem hiding this comment.
I'm not sure /etc/hosts should be recommended here. There are a lot of chroot applications where this would be unnecessary and/or undesireable.
Contributor
Author
Contributor
There was a problem hiding this comment.
Oh, sorry i didn't catch that. /etc/hosts isn't strictly required for network access. I don't feel super strongly about this. I guess I would be fine if /etc/hosts was qualified.
bobertlo
reviewed
Mar 24, 2020
bobertlo
reviewed
Mar 24, 2020
bobertlo
reviewed
Mar 24, 2020
Contributor
|
This looks really close to me. Thanks for your continued work on this. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft to address #130, for feedback.
i wasn't sure where to put this section in the Handbook, so i've just ended up putting it under the "Configuration" section. i've also added a link to this section from the "Base Requirements" page, with the idea of making people aware that a musl system might not be appropriate for their needs.
Also, would it be correct to say that those who need locale support should use glibc Void, rather than musl Void? (Locale support is certainly one of the reasons i use glibc rather than musl.)