fix(overlay): style inspector button differently when enabled#1069
Open
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Open
fix(overlay): style inspector button differently when enabled#1069skirtles-code wants to merge 1 commit intovuejs:mainfrom
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
@vue/devtools-electron
@vue/devtools-shared
@vue/devtools-ui
vite-plugin-vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #1067, this PR changes the styling of the
Toggle Component Inspectorbutton, so that it only shows in green when it is enabled. This is similar to how theToggle Vue DevToolsbutton is styled.Most of the code to do this already existed, but there was some ambiguity about what it means for the Vue inspector to be 'enabled'. I've split this into two separate things:
vueInspectorSupportedandvueInspectorEnabled. The former signifies whether the button can be shown, whereas the latter indicates that the button has been clicked and the user is actively trying to select a component.