Skip to content

fix(overlay): style inspector button differently when enabled #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirtles-code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(overlay): style inspector button differently when enabled #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/overlay/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function waitForClientInjection(iframe: HTMLIFrameElement, retry = 50, timeout =
}

const vueInspector = ref()
const vueInspectorEnabled = ref(false)

onDevToolsConnected(() => {
const rpcServer = getRpcServer<typeof functions>()
Expand All @@ -65,10 +66,12 @@ onDevToolsConnected(() => {

vueInspector.value.onEnabled = () => {
previousPanelVisible = panelVisible.value
vueInspectorEnabled.value = true
togglePanelVisible(undefined, false)
}

vueInspector.value.onDisabled = () => {
vueInspectorEnabled.value = false
togglePanelVisible(undefined, previousPanelVisible)
}
})
Expand All @@ -80,8 +83,8 @@ addEventListener('keyup', (e) => {
}
})

const vueInspectorEnabled = computed(() => {
return !!vueInspector.value
const vueInspectorSupported = computed(() => {
return !!(devtools.ctx.state.vitePluginDetected && vueInspector.value)
})

function enableVueInspector() {
Expand Down Expand Up @@ -123,7 +126,7 @@ const { getIframe } = useIframe(clientUrl, async () => {
<path fill="#35495E" d="M50.56 0L128 133.12L204.8 0h-47.36L128 51.2L97.92 0H50.56Z" />
</svg>
</div>
<template v-if="devtools.ctx.state.vitePluginDetected && vueInspectorEnabled">
<template v-if="vueInspectorSupported">
<div class="vue-devtools__panel-content vue-devtools__panel-divider" />
<div
class="vue-devtools__anchor-btn vue-devtools__panel-content vue-devtools__inspector-button"
Expand Down Expand Up @@ -187,6 +190,7 @@ const { getIframe } = useIframe(clientUrl, async () => {
align-items: center;
opacity: 0.8;
transition: opacity 0.2s ease-in-out;
cursor: pointer;

&:hover {
opacity: 1;
Expand All @@ -196,14 +200,9 @@ const { getIframe } = useIframe(clientUrl, async () => {
width: 14px;
height: 14px;
}

&.active {
cursor: pointer;
}
}

.panel-entry-btn {
cursor: pointer;
flex: none;
}

Expand Down
Loading